[PATCH v4 4/7] sched/fair: remove useless check in select_idle_core

From: Abel Wu <wuyun.abel@bytedance.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@suse.de>,
	Vincent Guittot <vincent.guittot@linaro.org>
Cc: Josh Don <joshdon@google.com>, Chen Yu <yu.c.chen@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	linux-kernel@vger.kernel.org, Abel Wu <wuyun.abel@bytedance.com>
Subject: [PATCH v4 4/7] sched/fair: remove useless check in select_idle_core
Date: Sun, 19 Jun 2022 20:04:48 +0800	[thread overview]
Message-ID: <20220619120451.95251-5-wuyun.abel@bytedance.com> (raw)
In-Reply-To: <20220619120451.95251-1-wuyun.abel@bytedance.com>

The function only gets called when sds->has_idle_cores is true which can
be possible only when sched_smt_present is enabled.

Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
---
 kernel/sched/fair.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index aba1dad19574..1cc86e76e38e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6256,9 +6256,6 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu
 	bool idle = true;
 	int cpu;
 
-	if (!static_branch_likely(&sched_smt_present))
-		return __select_idle_cpu(core, p);
-
 	for_each_cpu(cpu, cpu_smt_mask(core)) {
 		if (!available_idle_cpu(cpu)) {
 			idle = false;
-- 
2.31.1

