From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782EEC43334 for ; Fri, 24 Jun 2022 15:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbiFXPGt (ORCPT ); Fri, 24 Jun 2022 11:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbiFXPGr (ORCPT ); Fri, 24 Jun 2022 11:06:47 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B668841337; Fri, 24 Jun 2022 08:06:45 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 25E145C01DA; Fri, 24 Jun 2022 11:06:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 24 Jun 2022 11:06:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1656083205; x= 1656169605; bh=HjT+D1N1osG/gGZVW5EodSJ+cA7Y5+uYwHsMT33cSjw=; b=n bK4GxSQkrXj+mv+hxp0zW+0OPwRz1ButBUhIu7fSLnA4E96zxgrCE6dqG+f7LGaj 1eYe8fzdRODokUz9cyQ0F+WzcrjKUyZdsr1wXHKeUobFIO+dBdWe73eCLrT4dvGP JMME3INHUCBeKoM1Tt9+8J1zEKwJQW6rq80+eBFvxDqVI4z9hphrngJoRz/4s/zM qNFj/duSmCrpbH0COptguSv8y+MZMGUH2vAx8qelVI/h+m8iPfIs2U6hGVgEwrMo NfLaqGa3Amuy0wH3FrVdemzqS+yjWcUzUYNxSpDEeYitSBK4Ag2KsobqKTl4B9b+ AnIbNHdnkL3sUnBgscqgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656083205; x= 1656169605; bh=HjT+D1N1osG/gGZVW5EodSJ+cA7Y5+uYwHsMT33cSjw=; b=v qvtGt0IX13aS/uwgD8GVvCpfB8hHyJ/0gJwOIX4pnv7xyVK6OZs8LvC7XeekRBfh QLQdiKmF0UumsE4Z3zSVEbCUeHA7w7ZCLXLUk0Vjhem6gRcjY36zB/1QqSpjAj44 QeBFoWOubNPCoR/yS+F5vLCWAcx+0BEwox7WT6AYCmvz6hvJwwAal9jTNOovNwAs vqVBgRD6AcTDTEy18PP/h4oQ4gw4BLXd6XbgABvOW+EIko6ZmR4cBCUcGXGZe96j 7i+HklAmDtS9n7EIwWCUL2yAuVYEnM0KAj2iR7W4U5ixPZ8hs5IAml6blbUroInQ KiFjPkeTAArp/vpeW27tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnheptefgleeggfegkeekgffgleduieduffejffegveevkeejudektdduueet feetfefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Jun 2022 11:06:44 -0400 (EDT) Date: Fri, 24 Jun 2022 17:06:42 +0200 From: Maxime Ripard To: Paul Kocialkowski Cc: Dan Carpenter , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe Message-ID: <20220624150642.afkxpnut365i2wew@houat> References: <20220624143717.tykkcznvzq5e5qz2@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 04:46:36PM +0200, Paul Kocialkowski wrote: > Hi, >=20 > On Fri 24 Jun 22, 16:37, Maxime Ripard wrote: > > Hi, > >=20 > > On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote: > > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > > > The "regmap" is supposed to be initialized to NULL but it's used > > > > without being initialized. > > > >=20 > > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display cont= roller") > > > > Signed-off-by: Dan Carpenter > > >=20 > > > Nice catch, thanks a lot! > > >=20 > > > Acked-by: Paul Kocialkowski > >=20 > > Since you have the commit rights to drm-misc, you should apply it >=20 > Absolutely, I'm on my way to doing that. Giving your Acked-by is confusing then, because it's kind of implied if you apply it. > Do I need to reply to the emails with a message indicating that I > merged them or is using the tool sufficient? Sending an email is better, dim doesn't do that Maxime