From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: bjorn.andersson@linaro.org, robin.murphy@arm.com, hch@lst.de,
m.szyprowski@samsung.com, matthias.bgg@gmail.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com
Subject: Re: [PATCH 0/2] dma-mapping, remoteproc: Fix dma_mem leak after rproc_shutdown
Date: Fri, 24 Jun 2022 10:48:34 -0600 [thread overview]
Message-ID: <20220624164834.GA1736477@p14s> (raw)
In-Reply-To: <20220422062436.14384-1-mark-pk.tsai@mediatek.com>
On Fri, Apr 22, 2022 at 02:24:34PM +0800, Mark-PK Tsai wrote:
> Release dma coherent memory before rvdev is free in
> rproc_rvdev_release().
>
> Below is the kmemleak report:
> unreferenced object 0xffffff8051c1a980 (size 128):
> comm "sh", pid 4895, jiffies 4295026604 (age 15481.896s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<000000003a0f3ec0>] dma_declare_coherent_memory+0x44/0x11c
> [<00000000ad243164>] rproc_add_virtio_dev+0xb8/0x20c
> [<00000000d219c8e9>] rproc_vdev_do_start+0x18/0x24
> [<00000000e694b468>] rproc_start+0x22c/0x3e0
> [<000000000b938941>] rproc_boot+0x4a4/0x860
> [<000000003c4dc532>] state_store.52856+0x10c/0x1b8
> [<00000000df2297ac>] dev_attr_store+0x34/0x84
> [<0000000083a53bdb>] sysfs_kf_write+0x60/0xbc
> [<000000008ed830df>] kernfs_fop_write+0x198/0x458
> [<0000000072b9ad06>] __vfs_write+0x50/0x210
> [<00000000377d7469>] vfs_write+0xe4/0x1a8
> [<00000000c3fc594e>] ksys_write+0x78/0x144
> [<000000009aef6f4b>] __arm64_sys_write+0x1c/0x28
> [<0000000003496a98>] el0_svc_common+0xc8/0x22c
> [<00000000ea3fe7a3>] el0_svc_compat_handler+0x1c/0x28
> [<00000000d1a85a4e>] el0_svc_compat+0x8/0x24
>
> Mark-PK Tsai (2):
> dma-mapping: Add dma_release_coherent_memory to DMA API
> remoteproc: Fix dma_mem leak after rproc_shutdown
>
> drivers/remoteproc/remoteproc_core.c | 1 +
> include/linux/dma-map-ops.h | 3 +++
> kernel/dma/coherent.c | 10 ++++++++--
> 3 files changed, 12 insertions(+), 2 deletions(-)
Applied.
Thanks,
Mathieu
>
> --
> 2.18.0
>
prev parent reply other threads:[~2022-06-24 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 6:24 [PATCH 0/2] dma-mapping, remoteproc: Fix dma_mem leak after rproc_shutdown Mark-PK Tsai
2022-04-22 6:24 ` [PATCH 1/2] dma-mapping: Add dma_release_coherent_memory to DMA API Mark-PK Tsai
2022-04-22 6:24 ` [PATCH 2/2] remoteproc: Fix dma_mem leak after rproc_shutdown Mark-PK Tsai
2022-04-23 17:46 ` [PATCH 0/2] dma-mapping, " Christoph Hellwig
2022-05-23 10:15 ` Mark-PK Tsai
2022-05-23 10:24 ` Robin Murphy
2022-05-23 12:27 ` Mark-PK Tsai
2022-06-22 16:25 ` Mathieu Poirier
2022-06-23 5:42 ` Christoph Hellwig
2022-06-24 16:48 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624164834.GA1736477@p14s \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark-pk.tsai@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).