From: Maxime Ripard <maxime@cerno.tech>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe
Date: Mon, 27 Jun 2022 10:53:46 +0200 [thread overview]
Message-ID: <20220627085346.6fnzgygajdu7wncc@houat> (raw)
In-Reply-To: <YrXOTAR6koA1b8XJ@aptenodytes>
On Fri, Jun 24, 2022 at 04:46:36PM +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Fri 24 Jun 22, 16:37, Maxime Ripard wrote:
> > Hi,
> >
> > On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote:
> > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> > > > The "regmap" is supposed to be initialized to NULL but it's used
> > > > without being initialized.
> > > >
> > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > Nice catch, thanks a lot!
> > >
> > > Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> >
> > Since you have the commit rights to drm-misc, you should apply it
>
> Absolutely, I'm on my way to doing that.
>
> Do I need to reply to the emails with a message indicating that I merged them
> or is using the tool sufficient?
Going back on this, but it's fairly easy with b4 to generate the
messages that you applied them.
For example, I'm using:
cat mail | b4 am -t --no-cover -o - -P _ | dim apply-branch drm-misc-fixes
b4 am will retrieve the last version of the patch from lore (and only
the current patch with --no-cover -P _), add the tags (-t) and output it
on stdout (-o -) and pass it to dim apply-branch
Then, you can do
b4 ty -a && git send-email *.thanks && rm *.thanks
And it will send a mail for every patch you applied in the current branch
Maxime
next prev parent reply other threads:[~2022-06-27 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:08 [PATCH] drm: logicvc: Fix uninitialized variable in probe Dan Carpenter
2022-06-24 14:35 ` Paul Kocialkowski
2022-06-24 14:37 ` Maxime Ripard
2022-06-24 14:46 ` Paul Kocialkowski
2022-06-24 15:06 ` Maxime Ripard
2022-06-27 8:53 ` Maxime Ripard [this message]
2022-06-24 15:25 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627085346.6fnzgygajdu7wncc@houat \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).