linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Guowei Du <duguoweisz@gmail.com>,
	amir73il@gmail.com, repnop@google.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	duguowei <duguowei@xiaomi.com>
Subject: Re: [PATCH 6/6] fanotify: add current_user_instances node
Date: Tue, 28 Jun 2022 12:48:53 +0200	[thread overview]
Message-ID: <20220628104853.c3gcsvabqv2zzckd@wittgenstein> (raw)
In-Reply-To: <20220628104528.no4jarh2ihm5gxau@quack3>

On Tue, Jun 28, 2022 at 12:45:28PM +0200, Jan Kara wrote:
> On Tue 28-06-22 18:14:13, Guowei Du wrote:
> > From: duguowei <duguowei@xiaomi.com>
> > 
> > Add a node of sysctl, which is current_user_instances.
> > It shows current initialized group counts of system.
> > 
> > Signed-off-by: duguowei <duguowei@xiaomi.com>
> 
> Hum, I'm not sure about a wider context here but the changelog is certainly
> missing a motivation of this change - why do you need this counter? In
> particular because we already do maintain (and limit) the number of
> fanotify groups each user has allocated in a particular namespace...

Yeah, that's pretty strange as there's
/proc/sys/user/max_fanotify_groups
/proc/sys/user/max_fanotify_marks
it could be to have a ro counter that allows to display the current
number of groups? But that seems strange as we don't expose that
information anywhere for similar things. What would this be used for
even?

  reply	other threads:[~2022-06-28 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 10:14 [PATCH 6/6] fanotify: add current_user_instances node Guowei Du
2022-06-28 10:45 ` Jan Kara
2022-06-28 10:48   ` Christian Brauner [this message]
     [not found]     ` <CAC+1NxtAfbKOcW1hykyygScJgN7DsPKxLeuqNNZXLqekHgsG=Q@mail.gmail.com>
2022-06-28 12:29       ` Amir Goldstein
2022-06-28 12:56         ` Jan Kara
2022-06-28 13:55           ` Amir Goldstein
2022-06-28 14:25             ` Christian Brauner
2022-06-28 15:36               ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628104853.c3gcsvabqv2zzckd@wittgenstein \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=duguowei@xiaomi.com \
    --cc=duguoweisz@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=repnop@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).