From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9E0C433EF for ; Tue, 28 Jun 2022 13:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238222AbiF1NkT (ORCPT ); Tue, 28 Jun 2022 09:40:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346300AbiF1NkQ (ORCPT ); Tue, 28 Jun 2022 09:40:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1677E27161 for ; Tue, 28 Jun 2022 06:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656423615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JI0SMOllATTHDDnFWqGpyGyrKVYRMdL/R18gEZANfRM=; b=Zi6MapQD0ZFfko8om8AcD5RAU/gX3PfUy4EIHaG5Ga+vuhkd/8HTV8Q8Gp5dCUt4SLz7qD fwAynPK3MrqhPq1TQXR42UatGYmXULwe5SesBnWFTGGbRriN5IwRkxY1V3xdL0fFIfZOEG BqQ7qxsoqA7EE1Ldf4ByVWxt3lV+s3Q= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101--cjtZ6MdM1-kwSL_9FbIyw-1; Tue, 28 Jun 2022 09:40:06 -0400 X-MC-Unique: -cjtZ6MdM1-kwSL_9FbIyw-1 Received: by mail-qv1-f72.google.com with SMTP id ls8-20020a0562145f8800b0047078180732so12269670qvb.2 for ; Tue, 28 Jun 2022 06:40:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=JI0SMOllATTHDDnFWqGpyGyrKVYRMdL/R18gEZANfRM=; b=WPzhalt89cbLTQVnRESYPjvTJFeG1s/E9Zmyx9MkSiE+3McLNCNkPoCfpOzWcELol0 eaYBkN903lzrlIKZReMOI2ojYtkxgLv0ENtyqCFr0w6SWIEZpdHCFS4FzW2i1xIhgRhH R5+5uEXyiAWDyHTsBYEGZ584CFmLpCZMey05tVS4HTIPCEY7f5kcqZ5lLYCmISTBF+T2 uZH3pVs2eWyag0ZlkordnS3mOz9Kg6UfBtz0c4ZGdYK9A0fJvkv4M4nO2V6T0CPojsLg FfGdewa6Uf1eH9smE1lI8XnP0N4MyUS75bUTGSKE+nGF2ZNskdZGWv8/cnTQ7NTlqPAG PXoA== X-Gm-Message-State: AJIora/nH04I+RJuoTXfWH9T+2sd4RLXnOSEjpwaKgSxYybcdx16FT5R +As81FQHPwt+NF+PdCxw+ZlbyQ/gdgmGud5hzI4RBtOJ5bGapnoOYmZvwJlyjv2DYKCZXrsCE4S a//Ip+tFzM0aIyUfWWs4Zujc1 X-Received: by 2002:a05:6214:509c:b0:470:529a:1d76 with SMTP id kk28-20020a056214509c00b00470529a1d76mr3556356qvb.7.1656423605657; Tue, 28 Jun 2022 06:40:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uR1KivmrgHGt9XzHfmrBurNzgAa+UdSQyz20DSSdlK3mKA/+nt175Sp7jgxeEBsCjfL+bPrw== X-Received: by 2002:a05:6214:509c:b0:470:529a:1d76 with SMTP id kk28-20020a056214509c00b00470529a1d76mr3556306qvb.7.1656423605246; Tue, 28 Jun 2022 06:40:05 -0700 (PDT) Received: from sgarzare-redhat (host-87-11-6-149.retail.telecomitalia.it. [87.11.6.149]) by smtp.gmail.com with ESMTPSA id bl10-20020a05620a1a8a00b006a67eb4610fsm11214694qkb.116.2022.06.28.06.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 06:40:04 -0700 (PDT) Date: Tue, 28 Jun 2022 15:39:55 +0200 From: Stefano Garzarella To: Eugenio =?utf-8?B?UMOpcmV6?= Cc: netdev@vger.kernel.org, Jason Wang , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, "Michael S. Tsirkin" , Parav Pandit , Christophe JAILLET , lulu@redhat.com, tanuj.kamde@amd.com, Si-Wei Liu , Piotr.Uminski@intel.com, habetsm.xilinx@gmail.com, gautam.dawar@amd.com, pabloc@xilinx.com, Zhu Lingshan , lvivier@redhat.com, Longpeng , dinang@xilinx.com, martinh@xilinx.com, martinpo@xilinx.com, Eli Cohen , ecree.xilinx@gmail.com, Wu Zongyong , Dan Carpenter , hanand@xilinx.com, Xie Yongji , Zhang Min Subject: Re: [PATCH v6 1/4] vdpa: Add suspend operation Message-ID: <20220628133955.sj32sfounu4byggl@sgarzare-redhat> References: <20220623160738.632852-1-eperezma@redhat.com> <20220623160738.632852-2-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220623160738.632852-2-eperezma@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2022 at 06:07:35PM +0200, Eugenio Pérez wrote: >This operation is optional: It it's not implemented, backend feature bit >will not be exposed. > >Signed-off-by: Eugenio Pérez >--- > include/linux/vdpa.h | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h >index 7b4a13d3bd91..d282f464d2f1 100644 >--- a/include/linux/vdpa.h >+++ b/include/linux/vdpa.h >@@ -218,6 +218,9 @@ struct vdpa_map_file { > * @reset: Reset device > * @vdev: vdpa device > * Returns integer: success (0) or error (< 0) >+ * @suspend: Suspend or resume the device (optional) ^ IIUC we removed the resume operation (that should be done with reset), so should we update this documentation? Thanks, Stefano >+ * @vdev: vdpa device >+ * Returns integer: success (0) or error (< 0) > * @get_config_size: Get the size of the configuration space includes > * fields that are conditional on feature bits. > * @vdev: vdpa device >@@ -319,6 +322,7 @@ struct vdpa_config_ops { > u8 (*get_status)(struct vdpa_device *vdev); > void (*set_status)(struct vdpa_device *vdev, u8 status); > int (*reset)(struct vdpa_device *vdev); >+ int (*suspend)(struct vdpa_device *vdev); > size_t (*get_config_size)(struct vdpa_device *vdev); > void (*get_config)(struct vdpa_device *vdev, unsigned int offset, > void *buf, unsigned int len); >-- >2.31.1 >