linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kan.liang@linux.intel.com
To: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: alexander.shishkin@linux.intel.com, ak@linux.intel.com,
	adrian.hunter@intel.com, nadav.amit@gmail.com,
	Kan Liang <kan.liang@linux.intel.com>,
	Zhengjun Xing <zhengjun.xing@linux.intel.com>
Subject: [PATCH] perf/core: Fix the same task check in perf_event_set_output
Date: Mon, 11 Jul 2022 11:07:06 -0700	[thread overview]
Message-ID: <20220711180706.3418612-1-kan.liang@linux.intel.com> (raw)

From: Kan Liang <kan.liang@linux.intel.com>

With the --per-thread option, perf record errors out when sampling with
a hardware event and a software event as below.

 $ perf record -e cycles,dummy --per-thread ls
 failed to mmap with 22 (Invalid argument)

The same task is sampled with the two events. The IOC_OUTPUT is invoked
to share the mmap memory of the task between the events. In the
perf_event_set_output(), the event->ctx is used to check whether the
two events are attached to the same task. However, a hardware event and
a software event are from different task context. The check always
fails.

The task struct is stored in the event->hw.target for each per-thread
event. It can be used to determine whether two events are attached to
the same task.

The patch can also fix another issue reported months ago.
https://lore.kernel.org/all/92645262-D319-4068-9C44-2409EF44888E@gmail.com/
The event->ctx is not ready when the perf_event_set_output() is invoked
in the perf_event_open(), while the event->hw.target has been assigned
at the moment.

The problem should be a long time issue since commit c3f00c70276d
("perf: Separate find_get_context() from event initialization"). The
event->hw.target doesn't exist at that time. Here, the patch which
introduces the event->hw.target is used by the Fixes tag.

The problem should still exists between the broken patch and the
event->hw.target patch. This patch does not intend to fix that case.

Fixes: 50f16a8bf9d7 ("perf: Remove type specific target pointers")
Reviewed-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index b4d62210c3e5..22df79d3f19d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12080,7 +12080,7 @@ perf_event_set_output(struct perf_event *event, struct perf_event *output_event)
 	/*
 	 * If its not a per-cpu rb, it must be the same task.
 	 */
-	if (output_event->cpu == -1 && output_event->ctx != event->ctx)
+	if (output_event->cpu == -1 && output_event->hw.target != event->hw.target)
 		goto out;
 
 	/*
-- 
2.35.1


             reply	other threads:[~2022-07-11 18:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 18:07 kan.liang [this message]
2023-03-22 10:59 ` [PATCH] perf/core: Fix the same task check in perf_event_set_output Adrian Hunter
2023-03-22 13:42   ` Peter Zijlstra
2023-03-22 14:15     ` Adrian Hunter
2023-03-22 19:17       ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711180706.3418612-1-kan.liang@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=peterz@infradead.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).