From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C85C43334 for ; Tue, 12 Jul 2022 09:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232261AbiGLJDT (ORCPT ); Tue, 12 Jul 2022 05:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbiGLJDR (ORCPT ); Tue, 12 Jul 2022 05:03:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4DA7A4C88 for ; Tue, 12 Jul 2022 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657616595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nq1qiwtLifVGTobMDZeYWQmt6IOHO8N3mCb7gEISvPQ=; b=a6QAwYia2aC6rD4PZwtWyL4KSDwYQ2VNI/hvnixBNFPOdwIrYG3lJFcQcc1RWO8WkxNUTg a5505UkNU2pdud4W0mBBDAxWAsbDOTm2IiiAdeoHUIdg6TNMk3tBwHgU7c9jnnv+uipd1T vjpHV0flNkVTAsF/1Ycgt2DVXSuAkTY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-lAfOuTwkND-Pb2I1uq_WhA-1; Tue, 12 Jul 2022 05:03:08 -0400 X-MC-Unique: lAfOuTwkND-Pb2I1uq_WhA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 99239101AA48; Tue, 12 Jul 2022 09:03:07 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 532B21415118; Tue, 12 Jul 2022 09:03:07 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 919B018000A9; Tue, 12 Jul 2022 11:03:05 +0200 (CEST) Date: Tue, 12 Jul 2022 11:03:05 +0200 From: Gerd Hoffmann To: Geert Uytterhoeven Cc: Michel =?utf-8?Q?D=C3=A4nzer?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Linux Fbdev development list , Linux/m68k , DRI Development , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats Message-ID: <20220712090305.44jq3olwhwypisoc@sirius.home.kraxel.org> References: <0744671ac096a12f0d538906bd324efa71b11400.1657300532.git.geert@linux-m68k.org> <96a87833-d878-dde9-e335-9ea51a4ba406@mailbox.org> <20220712074715.kopstlvz4q6npaye@sirius.home.kraxel.org> <20220712083907.3ic7bltstaskz72n@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > As described above DRM_FORMAT_HOST_RGB565 means bigendian on bigendian > > hosts and little endian on little endian hosts. Which is not correct > > when your hardware does big endian no matter what. > > But (a) drm_driver_legacy_fb_format() uses DRM_FORMAT_HOST_RGB565 > if quirk_addfb_prefer_host_byte_order is set, Ah, right. Missed that in 'git grep' output. Given that traditional fbdev behavior is to expect native byte order using DRM_FORMAT_HOST_RGB565 there makes sense indeed. Scratch my comment about it being unused then ;) thanks, Gerd