From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: quic_manafm@quicinc.com, rui.zhang@intel.com, amitk@kernel.org,
lukasz.luba@arm.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/4] thermal/core: Avoid calling ->get_trip_temp() unnecessarily
Date: Fri, 15 Jul 2022 23:09:09 +0200 [thread overview]
Message-ID: <20220715210911.714479-2-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20220715210911.714479-1-daniel.lezcano@linaro.org>
As the trip temperature is already available when calling the function
handle_critical_trips(), pass it as a parameter instead of having this
function calling the ops again to retrieve the same data.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
v3:
- Massaged the patch title and the description
---
drivers/thermal/thermal_core.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d9f771b15ed8..f66036b3daae 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct thermal_zone_device *tz)
EXPORT_SYMBOL(thermal_zone_device_critical);
static void handle_critical_trips(struct thermal_zone_device *tz,
- int trip, enum thermal_trip_type trip_type)
+ int trip, int trip_temp, enum thermal_trip_type trip_type)
{
- int trip_temp;
-
- tz->ops->get_trip_temp(tz, trip, &trip_temp);
-
/* If we have not crossed the trip_temp, we do not care. */
if (trip_temp <= 0 || tz->temperature < trip_temp)
return;
@@ -394,7 +390,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type);
if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
- handle_critical_trips(tz, trip, type);
+ handle_critical_trips(tz, trip, trip_temp, type);
else
handle_non_critical_trips(tz, trip);
/*
--
2.25.1
next prev parent reply other threads:[~2022-07-15 21:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 21:09 [PATCH v3 1/4] thermal/core: Encapsulate the trip point crossed function Daniel Lezcano
2022-07-15 21:09 ` Daniel Lezcano [this message]
2022-07-18 4:59 ` [PATCH v3 2/4] thermal/core: Avoid calling ->get_trip_temp() unnecessarily Zhang Rui
2022-07-18 14:04 ` Daniel Lezcano
2022-07-19 1:01 ` Zhang Rui
2022-07-15 21:09 ` [PATCH v3 3/4] thermal/core: Build ascending ordered indexes for the trip points Daniel Lezcano
2022-07-18 5:28 ` Zhang Rui
2022-07-18 13:21 ` Daniel Lezcano
2022-07-19 1:14 ` Zhang Rui
2022-07-19 1:35 ` Zhang Rui
2022-07-19 7:22 ` Daniel Lezcano
2022-07-19 14:17 ` Zhang Rui
2022-07-21 9:34 ` Daniel Lezcano
2022-07-22 7:15 ` Zhang, Rui
2022-07-22 16:49 ` Rafael J. Wysocki
2022-07-18 14:32 ` Daniel Lezcano
2022-07-19 1:07 ` Zhang Rui
2022-07-15 21:09 ` [PATCH v3 4/4] thermal/core: Fix thermal trip cross point Daniel Lezcano
2022-07-18 5:30 ` Zhang Rui
2022-07-24 13:26 ` [thermal/core] 3c3e786e2b: BUG:KASAN:slab-out-of-bounds_in_handle_thermal_trip kernel test robot
2023-10-26 18:37 ` [PATCH v3 4/4] thermal/core: Fix thermal trip cross point Rafael J. Wysocki
2022-07-18 4:58 ` [PATCH v3 1/4] thermal/core: Encapsulate the trip point crossed function Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715210911.714479-2-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=quic_manafm@quicinc.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).