From: kernel test robot <lkp@intel.com>
To: Vineet Gupta <vgupta@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org
Subject: net/ipv4/tcp_cong.c:238:24: sparse: sparse: incorrect type in initializer (different address spaces)
Date: Sat, 16 Jul 2022 06:06:20 +0800 [thread overview]
Message-ID: <202207160525.YA4HOIPa-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9b59ec8d50a1f28747ceff9a4f39af5deba9540e
commit: e188f3330a13df904d77003846eafd3edf99009d ARC: cmpxchg/xchg: rewrite as macros to make type safe
date: 11 months ago
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220716/202207160525.YA4HOIPa-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e188f3330a13df904d77003846eafd3edf99009d
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout e188f3330a13df904d77003846eafd3edf99009d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arc SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> net/ipv4/tcp_cong.c:238:24: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct tcp_congestion_ops const [noderef] __rcu *_val_ @@ got struct tcp_congestion_ops *[assigned] ca @@
net/ipv4/tcp_cong.c:238:24: sparse: expected struct tcp_congestion_ops const [noderef] __rcu *_val_
net/ipv4/tcp_cong.c:238:24: sparse: got struct tcp_congestion_ops *[assigned] ca
net/ipv4/tcp_cong.c:238:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct tcp_congestion_ops const *prev @@ got struct tcp_congestion_ops const [noderef] __rcu *[assigned] _val_ @@
net/ipv4/tcp_cong.c:238:22: sparse: expected struct tcp_congestion_ops const *prev
net/ipv4/tcp_cong.c:238:22: sparse: got struct tcp_congestion_ops const [noderef] __rcu *[assigned] _val_
vim +238 net/ipv4/tcp_cong.c
317a76f9a44b43 Stephen Hemminger 2005-06-23 219
317a76f9a44b43 Stephen Hemminger 2005-06-23 220 /* Used by sysctl to change default congestion control */
6670e152447732 Stephen Hemminger 2017-11-14 221 int tcp_set_default_congestion_control(struct net *net, const char *name)
317a76f9a44b43 Stephen Hemminger 2005-06-23 222 {
317a76f9a44b43 Stephen Hemminger 2005-06-23 223 struct tcp_congestion_ops *ca;
6670e152447732 Stephen Hemminger 2017-11-14 224 const struct tcp_congestion_ops *prev;
6670e152447732 Stephen Hemminger 2017-11-14 225 int ret;
317a76f9a44b43 Stephen Hemminger 2005-06-23 226
6670e152447732 Stephen Hemminger 2017-11-14 227 rcu_read_lock();
6670e152447732 Stephen Hemminger 2017-11-14 228 ca = tcp_ca_find_autoload(net, name);
6670e152447732 Stephen Hemminger 2017-11-14 229 if (!ca) {
6670e152447732 Stephen Hemminger 2017-11-14 230 ret = -ENOENT;
0baf26b0fcd74b Martin KaFai Lau 2020-01-08 231 } else if (!bpf_try_module_get(ca, ca->owner)) {
6670e152447732 Stephen Hemminger 2017-11-14 232 ret = -EBUSY;
8d432592f30fcc Jonathon Reinhart 2021-05-01 233 } else if (!net_eq(net, &init_net) &&
8d432592f30fcc Jonathon Reinhart 2021-05-01 234 !(ca->flags & TCP_CONG_NON_RESTRICTED)) {
8d432592f30fcc Jonathon Reinhart 2021-05-01 235 /* Only init netns can set default to a restricted algorithm */
8d432592f30fcc Jonathon Reinhart 2021-05-01 236 ret = -EPERM;
6670e152447732 Stephen Hemminger 2017-11-14 237 } else {
6670e152447732 Stephen Hemminger 2017-11-14 @238 prev = xchg(&net->ipv4.tcp_congestion_control, ca);
6670e152447732 Stephen Hemminger 2017-11-14 239 if (prev)
0baf26b0fcd74b Martin KaFai Lau 2020-01-08 240 bpf_module_put(prev, prev->owner);
317a76f9a44b43 Stephen Hemminger 2005-06-23 241
6670e152447732 Stephen Hemminger 2017-11-14 242 ca->flags |= TCP_CONG_NON_RESTRICTED;
317a76f9a44b43 Stephen Hemminger 2005-06-23 243 ret = 0;
317a76f9a44b43 Stephen Hemminger 2005-06-23 244 }
6670e152447732 Stephen Hemminger 2017-11-14 245 rcu_read_unlock();
317a76f9a44b43 Stephen Hemminger 2005-06-23 246
317a76f9a44b43 Stephen Hemminger 2005-06-23 247 return ret;
317a76f9a44b43 Stephen Hemminger 2005-06-23 248 }
317a76f9a44b43 Stephen Hemminger 2005-06-23 249
:::::: The code at line 238 was first introduced by commit
:::::: 6670e152447732ba90626f36dfc015a13fbf150e tcp: Namespace-ify sysctl_tcp_default_congestion_control
:::::: TO: Stephen Hemminger <stephen@networkplumber.org>
:::::: CC: David S. Miller <davem@davemloft.net>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-07-15 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 22:06 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 12:02 net/ipv4/tcp_cong.c:238:24: sparse: sparse: incorrect type in initializer (different address spaces) kernel test robot
2022-08-28 4:12 kernel test robot
2022-03-09 6:20 kernel test robot
2021-12-04 18:52 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207160525.YA4HOIPa-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).