* [PATCH -next] bdi: remove enum wb_congested_state
@ 2022-07-19 8:33 Xiu Jianfeng
2022-07-26 10:25 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Xiu Jianfeng @ 2022-07-19 8:33 UTC (permalink / raw)
To: akpm, jack, neilb; +Cc: linux-kernel
enum wb_congested_state and the member 'congested' in bdi_writeback is
useless since commit a88f2096d5a2 ("remove congestion tracking framework"),
so remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
include/linux/backing-dev-defs.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
index e863c88df95f..ae12696ec492 100644
--- a/include/linux/backing-dev-defs.h
+++ b/include/linux/backing-dev-defs.h
@@ -28,11 +28,6 @@ enum wb_state {
WB_start_all, /* nr_pages == 0 (all) work pending */
};
-enum wb_congested_state {
- WB_async_congested, /* The async (write) queue is getting full */
- WB_sync_congested, /* The sync queue is getting full */
-};
-
enum wb_stat_item {
WB_RECLAIMABLE,
WB_WRITEBACK,
@@ -122,8 +117,6 @@ struct bdi_writeback {
atomic_t writeback_inodes; /* number of inodes under writeback */
struct percpu_counter stat[NR_WB_STAT_ITEMS];
- unsigned long congested; /* WB_[a]sync_congested flags */
-
unsigned long bw_time_stamp; /* last time write bw is updated */
unsigned long dirtied_stamp;
unsigned long written_stamp; /* pages written at bw_time_stamp */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] bdi: remove enum wb_congested_state
2022-07-19 8:33 [PATCH -next] bdi: remove enum wb_congested_state Xiu Jianfeng
@ 2022-07-26 10:25 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2022-07-26 10:25 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: akpm, jack, neilb, linux-kernel
On Tue 19-07-22 16:33:49, Xiu Jianfeng wrote:
> enum wb_congested_state and the member 'congested' in bdi_writeback is
> useless since commit a88f2096d5a2 ("remove congestion tracking framework"),
> so remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/backing-dev-defs.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
> index e863c88df95f..ae12696ec492 100644
> --- a/include/linux/backing-dev-defs.h
> +++ b/include/linux/backing-dev-defs.h
> @@ -28,11 +28,6 @@ enum wb_state {
> WB_start_all, /* nr_pages == 0 (all) work pending */
> };
>
> -enum wb_congested_state {
> - WB_async_congested, /* The async (write) queue is getting full */
> - WB_sync_congested, /* The sync queue is getting full */
> -};
> -
> enum wb_stat_item {
> WB_RECLAIMABLE,
> WB_WRITEBACK,
> @@ -122,8 +117,6 @@ struct bdi_writeback {
> atomic_t writeback_inodes; /* number of inodes under writeback */
> struct percpu_counter stat[NR_WB_STAT_ITEMS];
>
> - unsigned long congested; /* WB_[a]sync_congested flags */
> -
> unsigned long bw_time_stamp; /* last time write bw is updated */
> unsigned long dirtied_stamp;
> unsigned long written_stamp; /* pages written at bw_time_stamp */
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] bdi: remove enum wb_congested_state
@ 2022-07-19 8:30 Xiu Jianfeng
0 siblings, 0 replies; 3+ messages in thread
From: Xiu Jianfeng @ 2022-07-19 8:30 UTC (permalink / raw)
To: akpm, jack, neilb; +Cc: linux-kernel
enum wb_congested_state and the member 'congested' in bdi_writeback is
useless since commit a88f2096d5a2 ("remove congestion tracking framework"),
so remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
include/linux/backing-dev-defs.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
index e863c88df95f..ae12696ec492 100644
--- a/include/linux/backing-dev-defs.h
+++ b/include/linux/backing-dev-defs.h
@@ -28,11 +28,6 @@ enum wb_state {
WB_start_all, /* nr_pages == 0 (all) work pending */
};
-enum wb_congested_state {
- WB_async_congested, /* The async (write) queue is getting full */
- WB_sync_congested, /* The sync queue is getting full */
-};
-
enum wb_stat_item {
WB_RECLAIMABLE,
WB_WRITEBACK,
@@ -122,8 +117,6 @@ struct bdi_writeback {
atomic_t writeback_inodes; /* number of inodes under writeback */
struct percpu_counter stat[NR_WB_STAT_ITEMS];
- unsigned long congested; /* WB_[a]sync_congested flags */
-
unsigned long bw_time_stamp; /* last time write bw is updated */
unsigned long dirtied_stamp;
unsigned long written_stamp; /* pages written at bw_time_stamp */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-26 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 8:33 [PATCH -next] bdi: remove enum wb_congested_state Xiu Jianfeng
2022-07-26 10:25 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 8:30 Xiu Jianfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).