From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D938C43334 for ; Tue, 19 Jul 2022 14:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235378AbiGSOQr (ORCPT ); Tue, 19 Jul 2022 10:16:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237085AbiGSOQX (ORCPT ); Tue, 19 Jul 2022 10:16:23 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85B3EDFCF; Tue, 19 Jul 2022 06:47:13 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id mf4so27295977ejc.3; Tue, 19 Jul 2022 06:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ETPYyloEFdyBzQWObajkaBRkKPp4gQ7kPv9PBYe2erc=; b=YgbtmXtrMSveGqTKsERJ1+XFFwGK5viciTFGd14IPy1eWnpxCtJ0ZizkJJI34RP0E3 Wa7l7Sr1HLVkRQ0qCPY1Q3rmvvm1jHbl3Rd0/Z8WrObwCL6XdGHEWHurHlUTAI7jqFHh 4P66yW5eRdoKb8iQPxLXqYLFPqPbKO1aveL6CPiw1YPuSdDE32GRPzNJbYnXVbql/Jhw M/Er7ixdFA0anT3X57DKQ4ODT0zVCTDxTa4b9nSQR2L22OSaHVjP9b9igGnGW9pAHE0D /eZ3GErLNjQMXiHqXHCeRdvufrWXB0J2Xx737QQyFvVtDMrBATar3ADeR+UKtQY4qmKf +qRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ETPYyloEFdyBzQWObajkaBRkKPp4gQ7kPv9PBYe2erc=; b=yDSC3z90PDIhxb7oOgA6ECmex1K+oG4BKS6W4NeS0UzoPANlUSLjo4u3jh8oibnhqF rwKhU9gUimYKM/3t8mjBOlkmKBzsKawi3ZK6ZvirTB423E5zbkLXcTVX7AMigPXXDote iBFvhbXI6BQLoK8HCaaLBkDHyhNP4ce9Z+vmSyHxlwIoCjBgO+TEvihgsHOGSFrI+maJ UWfm2yWK+OP4NixL2pPL7rI5/QBIdXS/cTCzOXLUIfu1sKQzgLd9q/ZV/MJd/mdlD4jn aIBeo2ovSXA4LdR9LcrU+bIc5YmJ6MVCnBQLS4MQPXfx0aXEnLmVcRBD1QB8OkpbOsHc VCKA== X-Gm-Message-State: AJIora+2Tc6/gnT80hdEtXLJn9P6QxWuqf/DwHJZLCd3c1hsPOcRW0Pe nxlRTBcdF9LBnQYLTp00RiY= X-Google-Smtp-Source: AGRyM1vjayw4zUofmU9mkBXEG0SQV1Eh/t4ctobL0/nokmQOXLRxaBzoH+p1WkK9POQwfSw3SceF7g== X-Received: by 2002:a17:907:2887:b0:72b:68ce:2fff with SMTP id em7-20020a170907288700b0072b68ce2fffmr30090257ejc.423.1658238432105; Tue, 19 Jul 2022 06:47:12 -0700 (PDT) Received: from skbuf ([188.27.185.104]) by smtp.gmail.com with ESMTPSA id mb17-20020a170906eb1100b006fe9ec4ba9esm6693846ejb.52.2022.07.19.06.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:47:11 -0700 (PDT) Date: Tue, 19 Jul 2022 16:47:09 +0300 From: Vladimir Oltean To: Christian Marangi Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Jens Axboe , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary exposed function and make them static Message-ID: <20220719134709.um3rj2ocze65qqej@skbuf> References: <20220719005726.8739-1-ansuelsmth@gmail.com> <20220719005726.8739-1-ansuelsmth@gmail.com> <20220719005726.8739-17-ansuelsmth@gmail.com> <20220719005726.8739-17-ansuelsmth@gmail.com> <20220719132931.p3amcmjsjzefmukq@skbuf> <62d6b319.1c69fb81.6be76.d6b1@mx.google.com> <20220719134427.qlqm7xp4yyqs2zip@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719134427.qlqm7xp4yyqs2zip@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 04:44:27PM +0300, Vladimir Oltean wrote: > My request is that you prune the dangling definitions after each patch > that stops using something exported. Not "after" each patch, but "as part" of each patch.