From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] drm/panel-edp: Fix variable typo when saving hpd absent delay from DT
Date: Tue, 19 Jul 2022 16:38:56 -0400 [thread overview]
Message-ID: <20220719203857.1488831-4-nfraprado@collabora.com> (raw)
In-Reply-To: <20220719203857.1488831-1-nfraprado@collabora.com>
The value read from the "hpd-absent-delay-ms" property in DT was being
saved to the wrong variable, overriding the hpd_reliable delay. Fix the
typo.
Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s probed by EDID")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
drivers/gpu/drm/panel/panel-edp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 152e00eb846f..b3536d8600f4 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -738,7 +738,7 @@ static int generic_edp_panel_probe(struct device *dev, struct panel_edp *panel)
of_property_read_u32(dev->of_node, "hpd-reliable-delay-ms", &reliable_ms);
desc->delay.hpd_reliable = reliable_ms;
of_property_read_u32(dev->of_node, "hpd-absent-delay-ms", &absent_ms);
- desc->delay.hpd_reliable = absent_ms;
+ desc->delay.hpd_absent = absent_ms;
/* Power the panel on so we can read the EDID */
ret = pm_runtime_get_sync(dev);
--
2.37.0
next prev parent reply other threads:[~2022-07-19 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 20:38 [PATCH 0/3] New eDP panels and a bugfix Nícolas F. R. A. Prado
2022-07-19 20:38 ` [PATCH 1/3] drm/panel-edp: Add panel entry for R140NWF5 RH Nícolas F. R. A. Prado
2022-07-19 22:40 ` Doug Anderson
2022-07-20 7:49 ` AngeloGioacchino Del Regno
2022-07-20 18:52 ` Nícolas F. R. A. Prado
2022-07-20 22:50 ` Doug Anderson
2022-07-19 20:38 ` [PATCH 2/3] drm/panel-edp: Add panel entry for B120XAN01.0 Nícolas F. R. A. Prado
2022-07-19 22:41 ` Doug Anderson
2022-07-20 18:29 ` Nícolas F. R. A. Prado
2022-07-19 20:38 ` Nícolas F. R. A. Prado [this message]
2022-07-19 22:34 ` [PATCH 3/3] drm/panel-edp: Fix variable typo when saving hpd absent delay from DT André Almeida
2022-07-19 22:45 ` Doug Anderson
2022-07-19 22:49 ` Doug Anderson
2022-07-20 7:32 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719203857.1488831-4-nfraprado@collabora.com \
--to=nfraprado@collabora.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).