From: Phil Auld <pauld@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <vschneid@redhat.com>,
Steven Price <steven.price@arm.com>
Subject: [PATCH v4 0/2] cpuhp: fix some st->target issues
Date: Thu, 21 Jul 2022 10:28:50 -0400 [thread overview]
Message-ID: <20220721142852.2712895-1-pauld@redhat.com> (raw)
Fix a couple of cpuhp inconsistencies.
The first prevents target_store() from calling cpu_down() when
target == state which prevents the cpu being incorrectly marked
as dying. The second just makes the boot cpu have a valid cpuhp
target rather than 0 (CPU_OFFLINE) while being in state
CPU_ONLINE.
A further issue which these two patches don't address is that
the cpuX/online file looks at the device->offline state and can
thus get out of sync with the actual cpuhp state if the cpuhp
target is used to change state.
v3: Added code to make sure st->target == target in the nop case.
v4: Use WARN_ON in the case where state == target but st->target does
not.
Phil Auld (2):
cpuhp: make target_store() a nop when target == state
cpuhp: Set cpuhp target for boot cpu
kernel/cpu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.31.1
next reply other threads:[~2022-07-21 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 14:28 Phil Auld [this message]
2022-07-21 14:28 ` [PATCH v4 1/2] cpuhp: make target_store() a nop when target == state Phil Auld
2022-07-21 14:28 ` [PATCH v4 2/2] cpuhp: Set cpuhp target for boot cpu Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721142852.2712895-1-pauld@redhat.com \
--to=pauld@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).