From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: <pavel@ucw.cz>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <andy.shevchenko@gmail.com>, <linux-leds@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Subject: [RESEND PATCH v6 0/3] Add support for the TLC5925
Date: Fri, 22 Jul 2022 10:11:43 +0200 [thread overview]
Message-ID: <20220722081146.47262-1-jjhiblot@traphandler.com> (raw)
Resending the v6 of the series.
Pavel, do you have any comment/suggestion on this series ?
Thanks,
JJ
Original cover-letter:
This series adds the support for the TLC5925 LED controller.
This LED controller is driven through SPI. There is little internal logic
and it can be thought of as a deserializer + latches.
The TLC5925 itself drives up to 16 LEDs, but multiple TLC5925s can be
chained to drive more.
The first patch describes the dt bindings.
The second patch implements most of the driver and supports only
synchronous brightness setting (brightness_set_blocking).
The last patch implements the non-blocking version (brightness_set).
changes v5->v6:
* Make the 'ti,shif-register-length' property optional. The default
value is 16: the length of the shift register of a single TLC5925.
* fix minor issues in the binding description
changes v4->v5:
* add the headers that the code is a direct user of
* replace dev_err() with dev_err_probe() in ->probe()
* comestic changes (spaces, alignment and blank lines)
changes v3->v4:
* add missing MODULE_DEVICE_TABLE(of, ...)
* use dev_err_probe() to avoid spamming the log in case of deferred probe
* use bitmap ops instead of direct memory access + lock
* sort headers and a few other cosmetic changes.
changes v2->v3:
* fixed the yaml description of the bindings (now passes dt_binding_check)
* renamed shit-register-length into ti,shift-register-length and specify
its type
changes v1->v2:
* renamed property shift_register_length into shift-register-length
* add a SPI MODULE_DEVICE_TABLE structure
* fixed the yaml description of the bindings (now passes dt_binding_check)
Jean-Jacques Hiblot (3):
dt-bindings: leds: Add bindings for the TLC5925 controller
leds: Add driver for the TLC5925 LED controller
leds: tlc5925: Add support for non blocking operations
.../devicetree/bindings/leds/ti,tlc5925.yaml | 105 ++++++++++
drivers/leds/Kconfig | 6 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-tlc5925.c | 182 ++++++++++++++++++
4 files changed, 294 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/ti,tlc5925.yaml
create mode 100644 drivers/leds/leds-tlc5925.c
--
2.25.1
next reply other threads:[~2022-07-22 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:11 Jean-Jacques Hiblot [this message]
2022-07-22 8:11 ` [RESEND PATCH v6 1/3] dt-bindings: leds: Add bindings for the TLC5925 controller Jean-Jacques Hiblot
2022-07-22 8:11 ` [RESEND PATCH v6 2/3] leds: Add driver for the TLC5925 LED controller Jean-Jacques Hiblot
2022-07-30 21:27 ` Pavel Machek
2022-07-31 19:28 ` Andy Shevchenko
2022-08-04 20:23 ` Jean-Jacques Hiblot
2022-08-04 20:40 ` Andy Shevchenko
2022-08-04 21:04 ` Pavel Machek
2022-08-24 8:39 ` Jean-Jacques Hiblot
2022-08-24 8:55 ` Andy Shevchenko
2022-08-24 9:58 ` Jean-Jacques Hiblot
2022-08-24 10:18 ` Andy Shevchenko
2022-08-26 9:11 ` Linus Walleij
2022-07-22 8:11 ` [RESEND PATCH v6 3/3] leds: tlc5925: Add support for non blocking operations Jean-Jacques Hiblot
2022-07-30 21:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722081146.47262-1-jjhiblot@traphandler.com \
--to=jjhiblot@traphandler.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).