From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D0DCC43334 for ; Fri, 22 Jul 2022 16:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235302AbiGVQZg (ORCPT ); Fri, 22 Jul 2022 12:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbiGVQZe (ORCPT ); Fri, 22 Jul 2022 12:25:34 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B994F7539C for ; Fri, 22 Jul 2022 09:25:32 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id p11so3600906lfu.5 for ; Fri, 22 Jul 2022 09:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardline-pl.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2cHLZsYSzu3vlQWq2uTFZBxgK+nHwwF/vJBUwns59Ds=; b=n5bJ2manL/cCWuwR0ZJd2UvjhGDXg9VMCs+OvLl8bGyfqKipgVkFHueBbViZ2lEBA1 6NKiKenhcTxri61yQIaTCHoiV6+sOqsgzuGab5gL8C3miq/ows4KAHWtKz6TrXJvEGmf j4Dffqm/p76WMCjN/vqMZ7AG/++q67fMOnnx7kbUwLmSYewy2QwjAYS4w5V8bf3xo54H 4wkmllD15xq9EMw/cMlQcIe4twyMyi2w2808mTnrFhPlse51W3MSJ42rC9GL+9+wc0zQ 88JuNMU3uUiozQmZoQhCNIpSzTJFN0MeFUMQJbKOOE6ZqdFbVJFwttBW/m5ZhwknQU6a 4Xag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2cHLZsYSzu3vlQWq2uTFZBxgK+nHwwF/vJBUwns59Ds=; b=VgUJJVSaFpc0DCPfx+KtPKsQ8hi9KHpUE4zY79qQGKi2qjFPHEhWKHaAShJcrzzAvN SvSMhRH+SuUr39yBu03QmWl4ZNEmAAzPttKOtNfTM5mKjAPDL4ng1AqcfZgLMO/p3+oz ebKenMGJv7BzH58HtV4EL+SzEEoWG+cxzndkBV/wqYUbDezgvm2BFzTBsVtkXxn9cbIy GNfFPiwI6dbzIn9yBXQiLAiorq4qu9uIRZJ+iOG7MinJztuV83J7YfFHjiGoWb0f9Kmu M3E0oeVvjnom5BK4LgIrbwWJ9VAFk3AnuUTtKAMS+u6utKKZTvT1ghPxVLAGQXdxPB3j ORFQ== X-Gm-Message-State: AJIora+ygI31opN4MyMsw+lNdy1e/jVNtWaFfyZHCDHUMnew6gG+T3iN spaojzU2BlsfFgqYtqwU3PUDZQ== X-Google-Smtp-Source: AGRyM1sPLTtJuvAxH41K5c4T5wV2zD6vvOVSwpXKE6dWwQy/OWWh7eYNR6Txk9u9vVFJK0Gagcmh7g== X-Received: by 2002:a05:6512:3092:b0:489:dece:5539 with SMTP id z18-20020a056512309200b00489dece5539mr276918lfd.269.1658507130797; Fri, 22 Jul 2022 09:25:30 -0700 (PDT) Received: from localhost (89-64-117-232.dynamic.chello.pl. [89.64.117.232]) by smtp.gmail.com with ESMTPSA id b1-20020a2eb901000000b0025c8c3747bbsm1209127ljb.37.2022.07.22.09.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 09:25:30 -0700 (PDT) Date: Fri, 22 Jul 2022 18:25:29 +0200 From: =?utf-8?Q?Micha=C5=82?= Winiarski To: =?utf-8?B?TWHDrXJh?= Canal Cc: Matthew Auld , Arthur Grillo , siqueirajordao@riseup.net, David Airlie , Daniel Latypov , brendanhiggins@google.com, ML dri-devel , linux-kselftest@vger.kernel.org, n@nfraprado.net, Isabella Basso , andrealmeid@riseup.net, magalilemes00@gmail.com, Javier Martinez Canillas , kunit-dev@googlegroups.com, mwen@igalia.com, David Gow , Shuah Khan , =?utf-8?Q?Micha=C5=82?= Winiarski , tales.aparecida@gmail.com, kernel list , leandro.ribeiro@collabora.com, Thomas Zimmermann , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= Subject: Re: [PATCH v5 9/9] drm: selftest: convert drm_mm selftest to KUnit Message-ID: <20220722162529.wy4ox7pyjhno66lz@macragge.hardline.pl> References: <20220708203052.236290-1-maira.canal@usp.br> <20220708203052.236290-10-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2022 at 08:04:51AM -0300, Maíra Canal wrote: > On 7/22/22 07:35, Matthew Auld wrote: > > On Fri, 8 Jul 2022 at 21:32, Maíra Canal wrote: > >> > >> From: Arthur Grillo > >> > >> Considering the current adoption of the KUnit framework, convert the > >> DRM mm selftest to the KUnit API. > > > > Is there a plan to convert the corresponding selftest IGT that was > > responsible for running this (also drm_buddy) to somehow work with > > kunit? Previously these IGTs were always triggered as part of > > intel-gfx CI, but it looks like they are no longer run[1]. > > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/6433 > > Hi Matthew, > > Isabella sent a while ago a patch to IGT adding KUnit compatibility to > IGT [1], but there wasn't any feedback on the patch. I believe that soon > she will resend the series in order to make all KUnit DRM tests run on IGT. > > Any feedback on the patch is welcomed so that we can fix this issue as > soon as possible. > > [1] https://patchwork.freedesktop.org/patch/489985/ > > Best Regards, > - Maíra Canal Hi. Instead of going back to using IGT for *unit* tests, it would be a better idea to adjust the CI to just run the tests once at "build" time (just like e.g. checkpatch). We would then stop executing the same test multiple times on different machines (note that both DRM selftests and i915 "mock" selftests are pure unit tests - in other words, they don't need the hardware to be present), which would save some (small) amount of machine-time that can be utilized to do something that actually needs the hardware. Plus there's no need to maintain the kunit-runner in IGT. Note - we're currently going to lose "DMESG-WARN" detection if we go this route, but this is something that can be improved on the kunit-side. -Michał