From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13311C43334 for ; Mon, 25 Jul 2022 21:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236573AbiGYVSF (ORCPT ); Mon, 25 Jul 2022 17:18:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbiGYVSD (ORCPT ); Mon, 25 Jul 2022 17:18:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C89C22BF9 for ; Mon, 25 Jul 2022 14:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658783880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2NWyiHW5I2/geA1CEWbRzyNY6UqPET26DY1+YZLfRCI=; b=IW+dj+zsRytjcNScN4mlk62Gs5JMqzLI1jszrsKEv/WlC7VOvbo4nU7fIdiqpLbQO6X/kU zr49ZPKqHN4ptmKIjQ9ah7g3TS2eb2/hVMRMbSPqRZTkF00Okoaq5XSJYxqdmrNv4FAZRS 9dF5ld74lQGEup8xgCKIt7rIMkCEyu4= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-cBO-k2pMMCSQgBHW7uZ3Tw-1; Mon, 25 Jul 2022 17:17:59 -0400 X-MC-Unique: cBO-k2pMMCSQgBHW7uZ3Tw-1 Received: by mail-il1-f197.google.com with SMTP id b15-20020a92c56f000000b002dd2870c587so5105137ilj.20 for ; Mon, 25 Jul 2022 14:17:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=2NWyiHW5I2/geA1CEWbRzyNY6UqPET26DY1+YZLfRCI=; b=bSDaE+eJwlq7hxrEApHUtRfvCR4iwKnuD5VT4MVWvupfZ0OjzR8vmRGVoIcF0YKmju onP2dXqGzU6Tj77zPBpIy7wsnHPCzxIv2cDZy1W7EZOXnDXQWQ2IeIDZ/kbODrMmVIcl piXrJ/UOoLch0UwJbnbLLmwKsgy1nMcJy49jGkavNT8nkqO9MQqVjIkHBbVSm+eWSEfJ kqo3RY5ILYKBWd+lgEmahnQLKi95eC7z1A29vWGButH2zjK8v3HAkipO+b59YHwNaiZ7 hdCTTK2DXttoIam/Yc+gjXwekWg3U7eK/OrO72t/OuJJK5dQfL66Vbdq1LeYArgkSU5X nLXA== X-Gm-Message-State: AJIora+Ls6THSm/KLsK/dxfb0uFwbNXreAMXSaIBD0v780wiWWrdCB/2 S67FNaHHBUfrxLULq1ZGdOnzKKO1qG5eoJor7Jmyp4ShPtWlNd9Rho5cbfqhaES8oU/Cx9YLQzf zgefe0oQVxbxyYDDGJj0q9jUd X-Received: by 2002:a05:6e02:148c:b0:2dc:38ae:5c6a with SMTP id n12-20020a056e02148c00b002dc38ae5c6amr5550200ilk.115.1658783878650; Mon, 25 Jul 2022 14:17:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uXwuWmhW15O2ymdEn2whv1cs+NjXgAHFLetXDjRt4kzq/rgyjNkTHVfDxBgkGk5gC+VO8tdQ== X-Received: by 2002:a05:6e02:148c:b0:2dc:38ae:5c6a with SMTP id n12-20020a056e02148c00b002dc38ae5c6amr5550196ilk.115.1658783878367; Mon, 25 Jul 2022 14:17:58 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id h76-20020a6bb74f000000b0067baeb55e65sm6614546iof.38.2022.07.25.14.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 14:17:58 -0700 (PDT) Date: Mon, 25 Jul 2022 15:17:55 -0600 From: Alex Williamson To: Nicolin Chen Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API Message-ID: <20220725151755.12d53f2e.alex.williamson@redhat.com> In-Reply-To: <20220723020256.30081-1-nicolinc@nvidia.com> References: <20220723020256.30081-1-nicolinc@nvidia.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jul 2022 19:02:46 -0700 Nicolin Chen wrote: > This is a preparatory series for IOMMUFD v2 patches. It prepares for > replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() > with IOMMUFD version. > > There's a gap between these two versions: the vfio_iommu_type1 version > inputs a non-contiguous PFN list and outputs another PFN list for the > pinned physical page list, while the IOMMUFD version only supports a > contiguous address input by accepting the starting IO virtual address > of a set of pages to pin and by outputting to a physical page list. > > The nature of existing callers mostly aligns with the IOMMUFD version, > except s390's vfio_ccw_cp code where some additional change is needed > along with this series. Overall, updating to "iova" and "phys_page" > does improve the caller side to some extent. > > Also fix a misuse of physical address and virtual address in the s390's > crypto code. And update the input naming at the adjacent vfio_dma_rw(). > > This is on github: > https://github.com/nicolinc/iommufd/commits/vfio_pin_pages-v4 > > Terrence has tested this series on i915; Eric has tested on s390. > > Thanks! > > Changelog > v4: > * Dropped double-shifting at two gvt_unpin_guest_page calls, fixing > a bug that's discovered by Alex > * Added Reviewed-by from Anthony Krowiak > * Rebased on top of linux-vfio's next > v3: https://lore.kernel.org/kvm/20220708224427.1245-1-nicolinc@nvidia.com/ > * Added a patch to replace roundup with DIV_ROUND_UP in i915 gvt > * Dropped the "driver->ops->unpin_pages" and NULL checks in PATCH-1 > * Changed to use WARN_ON and separate into lines in PATCH-1 > * Replaced "guest" words with "user" and fix typo in PATCH-5 > * Updated commit log of PATCH-1, PATCH-6, and PATCH-10 > * Added Reviewed/Acked-by from Christoph, Jason, Kirti, Kevin and Eric > * Added Tested-by from Terrence (i915) and Eric (s390) > v2: https://lore.kernel.org/kvm/20220706062759.24946-1-nicolinc@nvidia.com/ > * Added a patch to make vfio_unpin_pages return void > * Added two patches to remove PFN list from two s390 callers > * Renamed "phys_page" parameter to "pages" for vfio_pin_pages > * Updated commit log of kmap_local_page() patch > * Added Harald's "Reviewed-by" to pa_ind patch > * Rebased on top of Alex's extern removal path > v1: https://lore.kernel.org/kvm/20220616235212.15185-1-nicolinc@nvidia.com/ > > Nicolin Chen (10): > vfio: Make vfio_unpin_pages() return void > drm/i915/gvt: Replace roundup with DIV_ROUND_UP > vfio/ap: Pass in physical address of ind to ap_aqic() > vfio/ccw: Only pass in contiguous pages > vfio: Pass in starting IOVA to vfio_pin/unpin_pages API > vfio/ap: Change saved_pfn to saved_iova > vfio/ccw: Change pa_pfn list to pa_iova list > vfio: Rename user_iova of vfio_dma_rw() > vfio/ccw: Add kmap_local_page() for memcpy > vfio: Replace phys_pfn with pages for vfio_pin_pages() > > .../driver-api/vfio-mediated-device.rst | 6 +- > arch/s390/include/asm/ap.h | 6 +- > drivers/gpu/drm/i915/gvt/kvmgt.c | 45 ++-- > drivers/s390/cio/vfio_ccw_cp.c | 195 +++++++++++------- > drivers/s390/crypto/ap_queue.c | 2 +- > drivers/s390/crypto/vfio_ap_ops.c | 54 +++-- > drivers/s390/crypto/vfio_ap_private.h | 4 +- > drivers/vfio/vfio.c | 54 ++--- > drivers/vfio/vfio.h | 8 +- > drivers/vfio/vfio_iommu_type1.c | 45 ++-- > include/linux/vfio.h | 9 +- > 11 files changed, 213 insertions(+), 215 deletions(-) > Applied to vfio next branch for v5.20. Thanks, Alex