From: Bjorn Helgaas <helgaas@kernel.org>
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v3 1/3] asm-generic: Support NO_IOPORT_MAP in pci_iomap.h
Date: Mon, 25 Jul 2022 12:10:59 -0500 [thread overview]
Message-ID: <20220725171059.GA5779@bhelgaas> (raw)
In-Reply-To: <20220725020737.1221739-2-shorne@gmail.com>
On Mon, Jul 25, 2022 at 11:07:35AM +0900, Stafford Horne wrote:
> When building OpenRISC PCI which has no ioport_map we get the following build
> error.
>
> lib/pci_iomap.c: In function 'pci_iomap_range':
> CC drivers/i2c/i2c-core-base.o
> ./include/asm-generic/pci_iomap.h:29:41: error: implicit declaration of function 'ioport_map'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
> 29 | #define __pci_ioport_map(dev, port, nr) ioport_map((port), (nr))
> | ^~~~~~~~~~
> lib/pci_iomap.c:44:24: note: in expansion of macro '__pci_ioport_map'
> 44 | return __pci_ioport_map(dev, start, len);
> | ^~~~~~~~~~~~~~~~
>
> This patch adds a NULL definition of __pci_ioport_map for architetures
> which do not support ioport_map.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
FWIW,
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
I assume this will go via some other tree; let me know if otherwise.
> ---
> include/asm-generic/pci_iomap.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/asm-generic/pci_iomap.h b/include/asm-generic/pci_iomap.h
> index 5a2f9bf53384..8fbb0a55545d 100644
> --- a/include/asm-generic/pci_iomap.h
> +++ b/include/asm-generic/pci_iomap.h
> @@ -25,6 +25,8 @@ extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
> #ifdef CONFIG_NO_GENERIC_PCI_IOPORT_MAP
> extern void __iomem *__pci_ioport_map(struct pci_dev *dev, unsigned long port,
> unsigned int nr);
> +#elif !defined(CONFIG_HAS_IOPORT_MAP)
> +#define __pci_ioport_map(dev, port, nr) NULL
> #else
> #define __pci_ioport_map(dev, port, nr) ioport_map((port), (nr))
> #endif
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-07-25 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 2:07 [PATCH v3 0/3] OpenRISC support for virt platform with PCI Stafford Horne
2022-07-25 2:07 ` [PATCH v3 1/3] asm-generic: Support NO_IOPORT_MAP in pci_iomap.h Stafford Horne
2022-07-25 17:10 ` Bjorn Helgaas [this message]
2022-07-25 21:25 ` Stafford Horne
2022-07-25 2:07 ` [PATCH v3 2/3] openrisc: Add pci bus support Stafford Horne
2022-07-29 3:37 ` Guenter Roeck
2022-07-29 5:50 ` Stafford Horne
2022-07-29 6:10 ` Guenter Roeck
2022-07-29 7:54 ` Stafford Horne
2022-07-25 2:07 ` [PATCH v3 3/3] openrisc: Add virt defconfig Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725171059.GA5779@bhelgaas \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).