From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org,
openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible
Date: Mon, 25 Jul 2022 16:56:50 -0600 [thread overview]
Message-ID: <20220725225650.GA2898332-robh@kernel.org> (raw)
In-Reply-To: <20220722114136.251415-2-tmaimon77@gmail.com>
On Fri, Jul 22, 2022 at 02:41:35PM +0300, Tomer Maimon wrote:
> Add a compatible string for Nuvoton BMC NPCM845 PSPI.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
> index b98203ca656d..a4e72e52af59 100644
> --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
> +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
> @@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver
> Nuvoton NPCM7xx SOC support two PSPI channels.
>
> Required properties:
> - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC
> + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX.
Who/What is Polog? Board/BMC vendor? If so, that should not be in SoC
bindings.
> + "nuvoton,npcm845-pspi" for Arbel NPCM8XX.
Same for Arbel.
To answer your question on fallback, just put:
"nuvoton,npcm845-pspi", "nuvoton,npcm750-pspi" for NPCM8XX BMC
> - #address-cells : should be 1. see spi-bus.txt
> - #size-cells : should be 0. see spi-bus.txt
> - specifies physical base address and size of the register.
> --
> 2.33.0
>
>
next prev parent reply other threads:[~2022-07-25 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:41 [PATCH v2 0/2] spi: npcm-pspi: add Arbel NPCM8XX support Tomer Maimon
2022-07-22 11:41 ` [PATCH v2 1/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible Tomer Maimon
2022-07-25 22:56 ` Rob Herring [this message]
2022-07-26 9:30 ` Tomer Maimon
2022-07-26 9:57 ` Krzysztof Kozlowski
2022-07-22 11:41 ` [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support Tomer Maimon
2022-07-22 18:31 ` Krzysztof Kozlowski
2022-07-22 18:43 ` Mark Brown
2022-07-22 18:47 ` Krzysztof Kozlowski
2022-07-22 18:57 ` Mark Brown
2022-07-24 8:44 ` Tomer Maimon
2022-07-26 9:47 ` Krzysztof Kozlowski
2022-07-26 19:32 ` Tomer Maimon
2022-07-27 6:51 ` Krzysztof Kozlowski
2022-08-15 15:44 ` [PATCH v2 0/2] spi: npcm-pspi: add Arbel NPCM8XX support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725225650.GA2898332-robh@kernel.org \
--to=robh@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).