* [PATCH v2 0/2] MT8186 pinctrl properties adjustments
@ 2022-07-25 11:07 Allen-KH Cheng
2022-07-25 11:07 ` [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property Allen-KH Cheng
2022-07-25 11:07 ` [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp Allen-KH Cheng
0 siblings, 2 replies; 7+ messages in thread
From: Allen-KH Cheng @ 2022-07-25 11:07 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chen-Yu Tsai, Allen-KH Cheng
Based on tag: next-20220720, linux-next/master.
In commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
PIN_CONFIG_DRIVE_STRENGTH_UA"), added support for using
drive-strength-microamp instead of mediatek,drive-strength-adv.
We replace the custom mediatek,drive-strength-adv property with
'drive-strength-microamp' in the mt8186 pinctrl dt-binding which
have a clearer meaning and is more standardized, also add
gpio-line-names property used in devicetrees to describe pin names.
changes since v1:
- fix the fixes tag
Allen-KH Cheng (2):
dt-bindings: pinctrl: mt8186: Add gpio-line-names property
dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp
.../bindings/pinctrl/pinctrl-mt8186.yaml | 31 +++----------------
1 file changed, 5 insertions(+), 26 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property
2022-07-25 11:07 [PATCH v2 0/2] MT8186 pinctrl properties adjustments Allen-KH Cheng
@ 2022-07-25 11:07 ` Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
2022-07-26 8:24 ` Linus Walleij
2022-07-25 11:07 ` [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp Allen-KH Cheng
1 sibling, 2 replies; 7+ messages in thread
From: Allen-KH Cheng @ 2022-07-25 11:07 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chen-Yu Tsai, Allen-KH Cheng
Add the 'gpio-line-names' property to mt8186-pinctrl, as this will be
used in devicetrees to describe pin names.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 8a2bb8608291..6784885edc5c 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -28,6 +28,8 @@ properties:
gpio-ranges:
maxItems: 1
+ gpio-line-names: true
+
reg:
description: |
Physical address base for gpio base registers. There are 8 different GPIO
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp
2022-07-25 11:07 [PATCH v2 0/2] MT8186 pinctrl properties adjustments Allen-KH Cheng
2022-07-25 11:07 ` [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property Allen-KH Cheng
@ 2022-07-25 11:07 ` Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
2022-07-26 8:25 ` Linus Walleij
1 sibling, 2 replies; 7+ messages in thread
From: Allen-KH Cheng @ 2022-07-25 11:07 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chen-Yu Tsai, Allen-KH Cheng
Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
drive-strength-microamp instead of mediatek,drive-strength-adv.
Similarly to the mt8192 and mt8195, there's no user of property
'mediatek,drive-strength-adv', hence removing it is safe.
Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../bindings/pinctrl/pinctrl-mt8186.yaml | 29 ++-----------------
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 6784885edc5c..1eeb885ce0c6 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -107,31 +107,8 @@ patternProperties:
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
- mediatek,drive-strength-adv:
- description: |
- Describe the specific driving setup property.
- For I2C pins, the existing generic driving setup can only support
- 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they
- can support 0.125/0.25/0.5/1mA adjustment. If we enable specific
- driving setup, the existing generic setup will be disabled.
- The specific driving setup is controlled by E1E0EN.
- When E1=0/E0=0, the strength is 0.125mA.
- When E1=0/E0=1, the strength is 0.25mA.
- When E1=1/E0=0, the strength is 0.5mA.
- When E1=1/E0=1, the strength is 1mA.
- EN is used to enable or disable the specific driving setup.
- Valid arguments are described as below:
- 0: (E1, E0, EN) = (0, 0, 0)
- 1: (E1, E0, EN) = (0, 0, 1)
- 2: (E1, E0, EN) = (0, 1, 0)
- 3: (E1, E0, EN) = (0, 1, 1)
- 4: (E1, E0, EN) = (1, 0, 0)
- 5: (E1, E0, EN) = (1, 0, 1)
- 6: (E1, E0, EN) = (1, 1, 0)
- 7: (E1, E0, EN) = (1, 1, 1)
- So the valid arguments are from 0 to 7.
- $ref: /schemas/types.yaml#/definitions/uint32
- enum: [0, 1, 2, 3, 4, 5, 6, 7]
+ drive-strength-microamp:
+ enum: [125, 250, 500, 1000]
bias-pull-down:
oneOf:
@@ -293,7 +270,7 @@ examples:
pinmux = <PINMUX_GPIO127__FUNC_SCL0>,
<PINMUX_GPIO128__FUNC_SDA0>;
bias-pull-up = <MTK_PULL_SET_RSEL_001>;
- mediatek,drive-strength-adv = <7>;
+ drive-strength-microamp = <1000>;
};
};
};
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property
2022-07-25 11:07 ` [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property Allen-KH Cheng
@ 2022-07-25 23:33 ` Rob Herring
2022-07-26 8:24 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-07-25 23:33 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: linux-kernel, Linus Walleij, linux-mediatek, devicetree,
Chen-Yu Tsai, Rob Herring, Matthias Brugger, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, angelogioacchino.delregno,
Krzysztof Kozlowski
On Mon, 25 Jul 2022 19:07:01 +0800, Allen-KH Cheng wrote:
> Add the 'gpio-line-names' property to mt8186-pinctrl, as this will be
> used in devicetrees to describe pin names.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp
2022-07-25 11:07 ` [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp Allen-KH Cheng
@ 2022-07-25 23:33 ` Rob Herring
2022-07-26 8:25 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-07-25 23:33 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: Project_Global_Chrome_Upstream_Group, Chen-Yu Tsai,
Linus Walleij, Matthias Brugger, linux-kernel, Rob Herring,
Krzysztof Kozlowski, angelogioacchino.delregno, linux-mediatek,
linux-arm-kernel, devicetree
On Mon, 25 Jul 2022 19:07:02 +0800, Allen-KH Cheng wrote:
> Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> drive-strength-microamp instead of mediatek,drive-strength-adv.
>
> Similarly to the mt8192 and mt8195, there's no user of property
> 'mediatek,drive-strength-adv', hence removing it is safe.
>
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/pinctrl/pinctrl-mt8186.yaml | 29 ++-----------------
> 1 file changed, 3 insertions(+), 26 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property
2022-07-25 11:07 ` [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
@ 2022-07-26 8:24 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2022-07-26 8:24 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chen-Yu Tsai
On Mon, Jul 25, 2022 at 1:07 PM Allen-KH Cheng
<allen-kh.cheng@mediatek.com> wrote:
> Add the 'gpio-line-names' property to mt8186-pinctrl, as this will be
> used in devicetrees to describe pin names.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp
2022-07-25 11:07 ` [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
@ 2022-07-26 8:25 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2022-07-26 8:25 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chen-Yu Tsai
On Mon, Jul 25, 2022 at 1:07 PM Allen-KH Cheng
<allen-kh.cheng@mediatek.com> wrote:
> Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> drive-strength-microamp instead of mediatek,drive-strength-adv.
>
> Similarly to the mt8192 and mt8195, there's no user of property
> 'mediatek,drive-strength-adv', hence removing it is safe.
>
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-26 8:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 11:07 [PATCH v2 0/2] MT8186 pinctrl properties adjustments Allen-KH Cheng
2022-07-25 11:07 ` [PATCH v2 1/2] dt-bindings: pinctrl: mt8186: Add gpio-line-names property Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
2022-07-26 8:24 ` Linus Walleij
2022-07-25 11:07 ` [PATCH v2 2/2] dt-bindings: pinctrl: mt8186: Add and use drive-strength-microamp Allen-KH Cheng
2022-07-25 23:33 ` Rob Herring
2022-07-26 8:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).