From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v2 6/7] tracing/user_events: Use bits vs bytes for enabled status page data
Date: Wed, 27 Jul 2022 09:45:17 -0400 [thread overview]
Message-ID: <20220727094517.25e9dee5@gandalf.local.home> (raw)
In-Reply-To: <20220727020147.GA1705@kbox>
On Tue, 26 Jul 2022 19:01:47 -0700
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> Ah, I see the confusion. Sorry.
>
> EVENT_STATUS_* are internal bits that aren't used with STATUS_MASK or
> STATUS_BYTE. It's only used to set and check the user event status byte
> for checking if anything is attached and outputting which probe is
> connected within the kernel side.
>
> STATUS_BYTE and STATUS_MASK take a bit in a bitmap and figure out which
> byte in the status mapping should be used and which bit in that byte
> should be set/reset (mask) when it's enabled/disabled via a probe. Both
> the user and kernel need to align on this logic.
>
> IE: Bits above the lower 3 of the index/bit of the event to enable is the byte
> and the lower 3 bits (& 7) is the actual bit to set.
>
> For example if the user_event with the index 1024 is enabled, we need to
> figure out which byte and bit represents that event when a probe is
> attached.
>
> I got into detail of this in the documentation for both a byte and long
> wise checking of these values.
>
> Hope that helps explain it.
Yes, but that should be in the comments above the code.
-- Steve
next prev parent reply other threads:[~2022-07-27 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 18:46 [PATCH v2 0/7] tracing/user_events: Update user_events ABI from Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 1/7] tracing/user_events: Fix repeated word in comments Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 2/7] tracing/user_events: Use NULL for strstr checks Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 3/7] tracing/user_events: Use WRITE instead of READ for io vector import Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 4/7] tracing/user_events: Ensure user provided strings are safely formatted Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 5/7] tracing/user_events: Use refcount instead of atomic for ref tracking Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 6/7] tracing/user_events: Use bits vs bytes for enabled status page data Beau Belgrave
2022-07-26 22:01 ` Steven Rostedt
2022-07-27 0:02 ` Beau Belgrave
2022-07-27 0:14 ` Steven Rostedt
2022-07-27 2:01 ` Beau Belgrave
2022-07-27 13:45 ` Steven Rostedt [this message]
2022-07-27 19:01 ` Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 7/7] tracing/user_events: Update ABI documentation to align to bits vs bytes Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727094517.25e9dee5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).