From: Lukas Czerner <lczerner@redhat.com>
To: Tadeusz Struk <tadeusz.struk@linaro.org>
Cc: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: try to flush inline data before calling BUG in writepages
Date: Wed, 27 Jul 2022 19:51:04 +0200 [thread overview]
Message-ID: <20220727175104.cnth7s452thpuosj@fedora> (raw)
In-Reply-To: <29a17172-c8c6-0e69-6e38-e482500d2ae3@linaro.org>
On Wed, Jul 27, 2022 at 10:40:25AM -0700, Tadeusz Struk wrote:
> Hi Lukas,
> On 7/27/22 10:25, Lukas Czerner wrote:
> > I don't think this is the right fix. We're in ext4_writepages, so at
> > this point I don't think an inode should have any actual inline data in
> > it. If it does it's a bug and the question is how did this get here?
> >
> > The inode is likely corrupted and it should have been noticed earliler
> > and it should never get here.
>
> Yes, that was just an attempt fix something that I'm not quite familiar
> with.
>
> Jan sent already a patch for that fixes it:
> https://lore.kernel.org/all/20220727155753.13969-1-jack@suse.cz/
>
> --
> Thanks,
> Tadeusz
>
Yeah, I just noticed sorry about that. I was missing the email context
for some reason.
Thanks!
-Lukas
prev parent reply other threads:[~2022-07-27 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 22:28 kernel BUG in ext4_writepages Tadeusz Struk
2022-05-19 12:23 ` Jan Kara
2022-05-19 15:40 ` Tadeusz Struk
2022-05-19 23:14 ` Tadeusz Struk
2022-05-20 9:50 ` Jan Kara
2022-05-20 14:50 ` Tadeusz Struk
2022-07-26 22:44 ` [PATCH] ext4: try to flush inline data before calling BUG in writepages Tadeusz Struk
2022-07-27 15:57 ` Jan Kara
2022-07-27 17:25 ` Lukas Czerner
2022-07-27 17:40 ` Tadeusz Struk
2022-07-27 17:51 ` Lukas Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727175104.cnth7s452thpuosj@fedora \
--to=lczerner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com \
--cc=tadeusz.struk@linaro.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).