From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel test robot <lkp@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Peter Rosin <peda@axentia.se>
Subject: [PATCH] mux: mmio: depends on REGMAP
Date: Wed, 27 Jul 2022 17:05:50 -0700 [thread overview]
Message-ID: <20220728000550.10495-1-rdunlap@infradead.org> (raw)
Fix build error when CONFIG_REGMAP is not set/enabled:
../drivers/mux/mmio.c: In function ‘mux_mmio_probe’:
../drivers/mux/mmio.c:76:34: error: storage size of ‘field’ isn’t known
76 | struct reg_field field;
../drivers/mux/mmio.c:102:29: error: implicit declaration of function ‘devm_regmap_field_alloc’ [-Werror=implicit-function-declaration]
102 | fields[i] = devm_regmap_field_alloc(dev, regmap, field);
../drivers/mux/mmio.c:76:34: warning: unused variable ‘field’ [-Wunused-variable]
76 | struct reg_field field;
Most drivers that use REGMAP select it, but trying to use 'select'
here causes a ton of recursive/circular dependency chains, so just
use "depends on" to prevent the build errors.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 73726380a26f ("mux: mmio-based syscon mux controller")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Peter Rosin <peda@axentia.se>
---
drivers/mux/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/mux/Kconfig
+++ b/drivers/mux/Kconfig
@@ -48,6 +48,7 @@ config MUX_GPIO
config MUX_MMIO
tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
depends on OF || COMPILE_TEST
+ depends on REGMAP
help
MMIO/Regmap register bitfield-controlled Multiplexer controller.
reply other threads:[~2022-07-28 0:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728000550.10495-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).