linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Hans de Goede <hdegoede@redhat.com>,
	Icenowy Zheng <icenowy@aosc.io>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Ripard <mripard@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: [PATCH 6/9] soc: sunxi: sram: Return void from the release function
Date: Sun, 31 Jul 2022 22:05:06 -0500	[thread overview]
Message-ID: <20220801030509.21966-7-samuel@sholland.org> (raw)
In-Reply-To: <20220801030509.21966-1-samuel@sholland.org>

There is no point in returning an error here, as the caller can do
nothing about it. In fact, all callers already ignore the return value.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/soc/sunxi/sunxi_sram.c       | 8 +++-----
 include/linux/soc/sunxi/sunxi_sram.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 09754cd1d57d..9622fd45f5e5 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -261,25 +261,23 @@ int sunxi_sram_claim(struct device *dev)
 }
 EXPORT_SYMBOL(sunxi_sram_claim);
 
-int sunxi_sram_release(struct device *dev)
+void sunxi_sram_release(struct device *dev)
 {
 	const struct sunxi_sram_data *sram_data;
 	struct sunxi_sram_desc *sram_desc;
 
 	if (!dev || !dev->of_node)
-		return -EINVAL;
+		return;
 
 	sram_data = sunxi_sram_of_parse(dev->of_node, NULL);
 	if (IS_ERR(sram_data))
-		return -EINVAL;
+		return;
 
 	sram_desc = to_sram_desc(sram_data);
 
 	spin_lock(&sram_lock);
 	sram_desc->claimed = false;
 	spin_unlock(&sram_lock);
-
-	return 0;
 }
 EXPORT_SYMBOL(sunxi_sram_release);
 
diff --git a/include/linux/soc/sunxi/sunxi_sram.h b/include/linux/soc/sunxi/sunxi_sram.h
index c5f663bba9c2..60e274d1b821 100644
--- a/include/linux/soc/sunxi/sunxi_sram.h
+++ b/include/linux/soc/sunxi/sunxi_sram.h
@@ -14,6 +14,6 @@
 #define _SUNXI_SRAM_H_
 
 int sunxi_sram_claim(struct device *dev);
-int sunxi_sram_release(struct device *dev);
+void sunxi_sram_release(struct device *dev);
 
 #endif /* _SUNXI_SRAM_H_ */
-- 
2.35.1


  parent reply	other threads:[~2022-08-01  3:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01  3:05 [PATCH 0/9] soc: sunxi: sram: Fixes and D1 support Samuel Holland
2022-08-01  3:05 ` [PATCH 1/9] dt-bindings: sram: sunxi-sram: Add D1 compatible string Samuel Holland
2022-08-02  9:03   ` Krzysztof Kozlowski
2022-08-01  3:05 ` [PATCH 2/9] soc: sunxi: sram: Actually claim SRAM regions Samuel Holland
2022-08-14 10:21   ` Jernej Škrabec
2022-08-01  3:05 ` [PATCH 3/9] soc: sunxi: sram: Prevent the driver from being unbound Samuel Holland
2022-08-14 10:26   ` Jernej Škrabec
2022-08-01  3:05 ` [PATCH 4/9] soc: sunxi: sram: Fix probe function ordering issues Samuel Holland
2022-08-14 10:34   ` Jernej Škrabec
2022-08-01  3:05 ` [PATCH 5/9] soc: sunxi: sram: Fix debugfs info for A64 SRAM C Samuel Holland
2022-08-14 18:28   ` Jernej Škrabec
2022-08-01  3:05 ` Samuel Holland [this message]
2022-08-14 18:29   ` [PATCH 6/9] soc: sunxi: sram: Return void from the release function Jernej Škrabec
2022-08-01  3:05 ` [PATCH 7/9] soc: sunxi: sram: Save a pointer to the OF match data Samuel Holland
2022-08-14 18:29   ` Jernej Škrabec
2022-08-01  3:05 ` [PATCH 8/9] soc: sunxi: sram: Export the LDO control register Samuel Holland
2022-08-14 18:32   ` Jernej Škrabec
2022-08-01  3:05 ` [PATCH 9/9] soc: sunxi: sram: Add support for the D1 system control Samuel Holland
2022-08-14 18:33   ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801030509.21966-7-samuel@sholland.org \
    --to=samuel@sholland.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).