From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Conor Dooley <mail@conchuod.ie>
Cc: conor.dooley@microchip.com, daire.mcnamara@microchip.com,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
robh+dt@kernel.org, thierry.reding@gmail.com
Subject: Re: [PATCH v7 2/4] riscv: dts: fix the icicle's #pwm-cells
Date: Tue, 2 Aug 2022 09:43:30 +0200 [thread overview]
Message-ID: <20220802074330.7t2hts2notnkqi4z@pengutronix.de> (raw)
In-Reply-To: <20220721172109.941900-3-mail@conchuod.ie>
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On Thu, Jul 21, 2022 at 06:21:08PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> \#pwm-cells for the Icicle kit's fabric PWM was incorrectly set to 2 &
> blindly overridden by the (out of tree) driver anyway. The core can
> support inverted operation, so update the entry to correctly report its
> capabilities.
>
> Fixes: 72560c6559b8 ("riscv: dts: microchip: add fpga fabric section to icicle kit")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> index 0d28858b83f2..e09a13aef268 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> @@ -8,7 +8,7 @@ core_pwm0: pwm@41000000 {
> compatible = "microchip,corepwm-rtl-v4";
> reg = <0x0 0x41000000 0x0 0xF0>;
> microchip,sync-update-mask = /bits/ 32 <0>;
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> clocks = <&fabric_clk3>;
> status = "disabled";
> };
I checked there are no consumers that need adaption, so:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-02 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 17:21 [PATCH v7 0/4] Microchip soft ip corePWM driver Conor Dooley
2022-07-21 17:21 ` [PATCH v7 1/4] dt-bindings: pwm: fix microchip corePWM's pwm-cells Conor Dooley
2022-08-02 7:45 ` Uwe Kleine-König
2022-07-21 17:21 ` [PATCH v7 2/4] riscv: dts: fix the icicle's #pwm-cells Conor Dooley
2022-08-02 7:43 ` Uwe Kleine-König [this message]
2022-07-21 17:21 ` [PATCH v7 3/4] pwm: add microchip soft ip corePWM driver Conor Dooley
2022-08-02 8:46 ` Uwe Kleine-König
2022-08-02 12:34 ` Conor.Dooley
2022-08-05 19:58 ` Uwe Kleine-König
2022-08-05 20:01 ` Conor.Dooley
2022-07-21 17:21 ` [PATCH v7 4/4] MAINTAINERS: add pwm to PolarFire SoC entry Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802074330.7t2hts2notnkqi4z@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).