From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Sebastian Würl" <sebastian.wuerl@ororatech.com>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Christian Pellegrin" <chripell@fsfe.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: Fix race condition on receive interrupt
Date: Thu, 4 Aug 2022 09:51:52 +0200 [thread overview]
Message-ID: <20220804075152.kqlp5weoz4grzbpp@pengutronix.de> (raw)
In-Reply-To: <CA+KjhYWukGxZUMMch_vFe=TNYCD0-jmuwO2520oUVDPE2kE1Rw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On 04.08.2022 09:45:07, Sebastian Würl wrote:
> On Thu, Aug 4, 2022 at 9:06 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> >
> > Another optimization idea: Do we need to re-read the eflag1? "eflag" is
> > for error handling only and you're optimizing the good path.
>
> I'd argue if a new message entered mailbox 1, this also potentially
> changed the error state, so we need to read it.
Makes sense!
> Thanks a lot for your feedback! Will post v3 soon.
>
> Also I'm sorry for spam in anyones inbox, I didn't get my mailing
> program to produce plain-text for the last mail.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-04 7:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 15:32 [PATCH] drivers/net/can/spi/mcp251x.c: Fix race condition on receive interrupt Sebastian Würl
2022-08-03 16:48 ` Andy Shevchenko
2022-08-03 16:50 ` Andy Shevchenko
2022-08-03 19:08 ` Marc Kleine-Budde
2022-08-03 18:59 ` Marc Kleine-Budde
2022-08-04 6:48 ` [PATCH] can: mcp251x: " Sebastian Würl
2022-08-04 7:06 ` Marc Kleine-Budde
2022-08-04 7:45 ` Sebastian Würl
2022-08-04 7:51 ` Marc Kleine-Budde [this message]
2022-08-04 7:59 ` [PATCH v3] " Sebastian Würl
2022-08-04 8:14 ` [PATCH v4] " Sebastian Würl
2022-08-04 8:28 ` Marc Kleine-Budde
2022-08-04 18:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804075152.kqlp5weoz4grzbpp@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.wuerl@ororatech.com \
--cc=socketcan@hartkopp.net \
--cc=stefan.maetje@esd.eu \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).