linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Marek Vasut <marex@denx.de>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	robert.chiras@nxp.com, laurentiu.palcu@nxp.com,
	NXP Linux Team <linux-imx@nxp.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Robert Foss <robert.foss@linaro.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: imx8mm lcdif->dsi->adv7535 no video, no errors
Date: Thu, 4 Aug 2022 11:38:29 +0200	[thread overview]
Message-ID: <20220804093829.42kdelp7u4r743nv@pengutronix.de> (raw)
In-Reply-To: <CAPY8ntBBz56Es=pK+KpqhyYLUET95DT_zE6gorOWx4WkCSxJAg@mail.gmail.com>

Hi Dave, Adam,

On 22-08-03, Dave Stevenson wrote:
> Hi Adam
> 
> On Wed, 3 Aug 2022 at 12:03, Adam Ford <aford173@gmail.com> wrote:

...

> > > Did managed to get access to the ADV7535 programming guide? This is the
> > > black box here. Let me check if I can provide you a link with our repo
> > > so you can test our current DSIM state if you want.
> >
> > I do have access to the programming guide, but it's under NDA, but
> > I'll try to answer questions if I can.
> 
> Not meaning to butt in, but I have datasheets for ADV7533 and 7535
> from previously looking at these chips.

Thanks for stepping into :)

> Mine fairly plainly states:
> "The DSI receiver input supports DSI video mode operation only, and
> specifically, only supports nonburst mode with sync pulses".

I've read this also, and we are working in nonburst mode with sync
pulses. I have no access to an MIPI-DSI analyzer therefore I can't
verify it.

> Non-burst mode meaning that the DSI pixel rate MUST be the same as the
> HDMI pixel rate.

On DSI side you don't have a pixel-clock instead there is bit-clock.

> Section 6.1.1 "DSI Input Modes" of adv7533_hardware_user_s_guide is
> even more explicit about the requirement of DSI timing matching

Is it possible to share the key points of the requirements?

> The NXP kernel switching down to an hs_clk of 445.5MHz would therefore
> be correct for 720p operation.

It should be absolute no difference if you work on 891MHz with 2 lanes
or on 445.5 MHz with 4 lanes. What must be ensured is that you need the
minimum required bandwidth which is roughly: 1280*720*24*60 = 1.327
GBps.

> If you do program the manual DSI divider register to allow a DSI pixel
> rate of 148.5MHz vs HDMI pixel rate of 74.25MHz, you'd be relying on

There is no such DSI pixel rate to be precise, we only have a DSI bit
clock/rate.

> the ADV753x having at least a half-line FIFO between DSI rx and HDMI
> tx to compensate for the differing data rates. I see no reference to
> such, and I'd be surprised if it was more than a half dozen pixels to
> compensate for the jitter in the cases where the internal timing
> generator is mandatory due to fractional bytes.

This is interesting and would proofs our assumption that the device
don't have a FIFO :)

Our assumptions (we don't have the datasheet/programming manual):
  - HDMI part is fetching 3 bytes per HDMI pixclk
  - Ratio between dsi-clk and hdmi-pixelclk must be 3 so the DSI and
    HDMI are in sync. So from bandwidth pov there are no differences
    between:
      - HDMI: 74.25 MHz * 24 Bit  = 1782.0 MBit/s
      - DSI:    891 MHz * 2 lanes = 1782.0 MBit/s (dsi-clock: 445.5 )
      - DSI:  445.5 MHz * 4 lanes = 1782.0 MBit/s (dsi-clock: 222.75)

    But the ratio is different and therefore the faster clocking option
    let something 'overflow'.

Anyway, but all this means that Adam should configure the
burst-clock-rate to 445.5 and set the lanes to 4. But this doesn't work
either and now we are back on my initial statement -> the driver needs
some attention.

Regards,
  Marco

  parent reply	other threads:[~2022-08-04  9:38 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 15:15 imx8mm lcdif->dsi->adv7535 no video, no errors Adam Ford
2022-08-01  6:19 ` Marco Felsch
2022-08-01 10:54   ` Adam Ford
2022-08-01 12:15     ` Adam Ford
2022-08-01 19:33 ` Fabio Estevam
2022-08-01 20:07   ` Adam Ford
2022-08-01 22:57     ` Adam Ford
2022-08-01 22:55   ` Marco Felsch
2022-08-01 23:11     ` Fabio Estevam
2022-08-02  1:39       ` Adam Ford
2022-08-02  1:53         ` Fabio Estevam
2022-08-02  2:29           ` Adam Ford
2022-08-02  8:08             ` Marco Felsch
2022-08-02 12:13               ` Adam Ford
2022-08-02 13:51                 ` Adam Ford
2022-08-03  2:14                   ` Adam Ford
2022-08-03  6:20                     ` Marco Felsch
2022-08-03 11:02                       ` Adam Ford
2022-08-03 12:17                         ` Dave Stevenson
2022-08-03 12:31                           ` Adam Ford
2022-08-03 13:41                             ` Dave Stevenson
2022-08-04 10:27                               ` Marco Felsch
2022-08-04 12:03                                 ` Dave Stevenson
2022-08-04 13:16                                   ` Marco Felsch
2022-08-04  9:57                             ` Marco Felsch
2022-08-04  9:38                           ` Marco Felsch [this message]
2022-08-04 11:31                             ` Dave Stevenson
2022-08-04 12:51                               ` Marco Felsch
2022-08-04 13:12                                 ` Adam Ford
2022-08-04 13:23                                   ` Marco Felsch
2022-08-04 14:43                                   ` Biju Das
2022-08-04 14:51                                 ` Dave Stevenson
2022-08-05  0:05                                   ` Adam Ford
2022-08-05  8:44                                     ` Biju Das
2022-08-05 10:55                                       ` Adam Ford
2022-08-05 12:56                                         ` Adam Ford
2022-08-05 21:05                                           ` Adam Ford
2022-08-08  2:49                                             ` Adam Ford
2022-08-08  8:54                                               ` Marco Felsch
2022-08-08 10:13                                                 ` Adam Ford
2022-08-09  3:45                                                   ` Adam Ford
2022-08-04  8:41                         ` Marco Felsch
2022-08-03  5:56                   ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220804093829.42kdelp7u4r743nv@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=airlied@linux.ie \
    --cc=andrzej.hajda@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=laurentiu.palcu@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marex@denx.de \
    --cc=narmstrong@baylibre.com \
    --cc=robert.chiras@nxp.com \
    --cc=robert.foss@linaro.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).