From: Qais Yousef <qais.yousef@arm.com>
To: Ingo Molnar <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: linux-kernel@vger.kernel.org, Xuewen Yan <xuewen.yan94@gmail.com>,
Lukasz Luba <lukasz.luba@arm.com>, Wei Wang <wvw@google.com>,
Jonathan JMChen <Jonathan.JMChen@mediatek.com>,
Hank <han.lin@mediatek.com>, Qais Yousef <qais.yousef@arm.com>
Subject: [PATCH v2 0/9] Fix relationship between uclamp and fits_capacity()
Date: Thu, 4 Aug 2022 15:36:00 +0100 [thread overview]
Message-ID: <20220804143609.515789-1-qais.yousef@arm.com> (raw)
Relationship between uclamp and fits_capacity() is currently broken. Mostly due
to how uclamp should interact with migration margin and capacity pressure. But
also due not all users were converted to consider uclamp before calling
fits_capacity(). Namely cpu_overutilized().
The meat of the series is patch 1 where we introduce a new function,
util_fits_cpu(), that takes uclamp into account. The new function should
replace all call sits to fits_capacity(), which what subsequent patches do.
Except for patch 7 where we fix handling of early exit condition in
find_energy_efficient_cpu(AKA feec()) that must be uclamp aware too.
util_fits_cpu() will revert back to a simple call to fits_capacity() if uclamp
is not being used on the system.
Last two patches still need testing and verification, but they address the
various thermal handling issues raised in v1. We can re-order the patches, but
added at the end to facilitate review at this stage. Hope the approach and the
logic make sense.
I'll be on holidays, so if I don't respond to review comments fast enough,
apologies in advance.
Changes in v2:
* use uclamp_rq_is_idle() in uclamp_rq_util_with() (Xuewen)
* Simplify logic in update_sg_wakeup_stats() when converting
task_fits_cpu() (Vincent)
* Better handling of thermal pressure (Vincent)
- We consider thermal pressure for uclamp_min in patch 1
- 2 new patches to handle capacity inversion which improves handling
when:
+ There're multiple big cpus on separate perf domains.
+ A task is boosted by uclamp_min and inspite of thermal
pressure, the big cpu is still the best placement.
e.g: p0->util_avg = 300, p0->uclamp_min = 1024
This task should stay on big CPU until thermal pressure is in
capacity inversion.
v1 discussion: https://lore.kernel.org/lkml/20220629194632.1117723-1-qais.yousef@arm.com/
Thanks for all reviewers on v1!
Qais Yousef (9):
sched/uclamp: Fix relationship between uclamp and migration margin
sched/uclamp: Make task_fits_capacity() use util_fits_cpu()
sched/uclamp: Fix fits_capacity() check in feec()
sched/uclamp: Make select_idle_capacity() use util_fits_cpu()
sched/uclamp: Make asym_fits_capacity() use util_fits_cpu()
sched/uclamp: Make cpu_overutilized() use util_fits_cpu()
sched/uclamp: Cater for uclamp in find_energy_efficient_cpu()'s early
exit condition
sched/fair: Detect capacity inversion
sched/fair: Consider capacity inversion in util_fits_cpu()
kernel/sched/core.c | 10 +-
kernel/sched/fair.c | 290 ++++++++++++++++++++++++++++++++++++++-----
kernel/sched/sched.h | 70 ++++++++++-
3 files changed, 329 insertions(+), 41 deletions(-)
--
2.25.1
next reply other threads:[~2022-08-04 14:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 14:36 Qais Yousef [this message]
2022-08-04 14:36 ` [PATCH v2 1/9] sched/uclamp: Fix relationship between uclamp and migration margin Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-11-04 17:35 ` [PATCH v2 1/9] " Valentin Schneider
2022-11-05 19:24 ` Qais Yousef
2022-11-07 18:58 ` Valentin Schneider
2022-11-08 11:33 ` Qais Yousef
2022-11-09 10:33 ` Dietmar Eggemann
2022-08-04 14:36 ` [PATCH v2 2/9] sched/uclamp: Make task_fits_capacity() use util_fits_cpu() Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 3/9] sched/uclamp: Fix fits_capacity() check in feec() Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 4/9] sched/uclamp: Make select_idle_capacity() use util_fits_cpu() Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 5/9] sched/uclamp: Make asym_fits_capacity() " Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 6/9] sched/uclamp: Make cpu_overutilized() " Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 7/9] sched/uclamp: Cater for uclamp in find_energy_efficient_cpu()'s early exit condition Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-08-04 14:36 ` [PATCH v2 8/9] sched/fair: Detect capacity inversion Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-11-09 10:42 ` [PATCH v2 8/9] " Dietmar Eggemann
2022-11-12 19:35 ` Qais Yousef
2022-11-16 17:45 ` Dietmar Eggemann
2022-11-20 21:30 ` Qais Yousef
2022-08-04 14:36 ` [PATCH v2 9/9] sched/fair: Consider capacity inversion in util_fits_cpu() Qais Yousef
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Qais Yousef
2022-11-04 17:35 ` [PATCH v2 9/9] " Valentin Schneider
2022-11-05 20:41 ` Qais Yousef
2022-11-07 18:58 ` Valentin Schneider
2022-11-08 11:51 ` Qais Yousef
2022-11-09 10:43 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804143609.515789-1-qais.yousef@arm.com \
--to=qais.yousef@arm.com \
--cc=Jonathan.JMChen@mediatek.com \
--cc=dietmar.eggemann@arm.com \
--cc=han.lin@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).