From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disable touchscreen pull-up
Date: Sat, 6 Aug 2022 22:27:30 +0530 [thread overview]
Message-ID: <20220806165730.GQ14384@thinkpad> (raw)
In-Reply-To: <20220805092317.4985-5-johan+linaro@kernel.org>
On Fri, Aug 05, 2022 at 11:23:14AM +0200, Johan Hovold wrote:
> The (optional) touchscreen interrupt line has an external pull-up so
> disable the internal one as is done for the keyboard and touchpad.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 562b4458e039..85efce641a4e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -363,7 +363,7 @@ ts0_default: ts0-default-state {
> int-n {
> pins = "gpio175";
> function = "gpio";
> - bias-pull-up;
> + bias-disable;
> };
>
> reset-n {
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-08-06 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 9:23 [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and alt. touchpad Johan Hovold
2022-08-05 9:23 ` [PATCH 1/7] arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up Johan Hovold
2022-08-06 16:54 ` Manivannan Sadhasivam
2022-08-05 9:23 ` [PATCH 2/7] arm64: dts: qcom: sc8280xp-crd: move HID pin config Johan Hovold
2022-08-06 16:56 ` Manivannan Sadhasivam
2022-08-05 9:23 ` [PATCH 3/7] arm64: dts: qcom: sc8280xp-crd: mark HID wakeup sources Johan Hovold
2022-08-06 16:57 ` Manivannan Sadhasivam
2022-08-05 9:23 ` [PATCH 4/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disable touchscreen pull-up Johan Hovold
2022-08-06 16:57 ` Manivannan Sadhasivam [this message]
2022-08-05 9:23 ` [PATCH 5/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config Johan Hovold
2022-08-06 16:57 ` Manivannan Sadhasivam
2022-08-05 9:23 ` [PATCH 6/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: mark HID wakeup sources Johan Hovold
2022-08-06 16:58 ` Manivannan Sadhasivam
2022-08-05 9:23 ` [PATCH 7/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad Johan Hovold
2022-08-06 16:59 ` Manivannan Sadhasivam
2022-08-05 11:02 ` [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and alt. touchpad Konrad Dybcio
2022-08-05 12:17 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220806165730.GQ14384@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).