From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE5C8C25B06 for ; Sat, 6 Aug 2022 16:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbiHFQ6Z (ORCPT ); Sat, 6 Aug 2022 12:58:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233957AbiHFQ6R (ORCPT ); Sat, 6 Aug 2022 12:58:17 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07B29DED5 for ; Sat, 6 Aug 2022 09:58:05 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id o5-20020a17090a3d4500b001ef76490983so5587404pjf.2 for ; Sat, 06 Aug 2022 09:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gwFfS7FgstQLbRyJIK3YRj+mJRK29ux6Bl+pErHZDnY=; b=kXnYRlqgtGyktsODjODWihItFMICAbPOj95ikmPuA4ZKki2dyIvj64m5ESMfxVr5wS zoo2rCjSc5qpGU/Hsxx+o7jSeF5kCv+4LzxBRL3vb5MncTAzoL2FO14yBwpwJCzbm95h cSmonlhRGCEtW5F025mqyohVfvuoe+AXRTp91OmTQ/PwiDPi8oANfe0ejeaveJgoH9ai +mtu746bV/XAHwpnw84D6xZfmPP6/OvFt4bvgujSDMROGB2FfHJuLQv8w+9DU4qydSzf 12hcFpMSbcnDLfZLm3HTQvTzAQ6HHtet+Z2RW+5fjh4QY52U5PsEYzCiEIDrvZsTCY2V V8cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gwFfS7FgstQLbRyJIK3YRj+mJRK29ux6Bl+pErHZDnY=; b=x+yN3X/wVLy4LT02OtXbIl8oKMkayI2UM2OQO5B17ncfzmRQkPn/vcNyACwingMvc1 fS7/yuQ+2BBYUWfh9g4Jw7Kq28gy9v2WRDHSpAbgKDnSg3Jy2MBGuranIUUE2IJvHjEV DUikZnPT9TovJTrbvky6dHWtuKVdMZl4rIYeF1gqWP8d5QqmpRXbaeCMRMitd2mUskQV Q4DzgOapKN2ZCrdq963Fpj5vEPmz3+yoQRxD2TNMKEU53GiHOfPLkhdVKIYWzBz/kUcJ IoimALlMLbCbBOhAWFmJxeT/GQJGxQElNnc2nRdBGC9COHUJ9KllngDupsmGvnbOw8Ji 0IUA== X-Gm-Message-State: ACgBeo00sxR8X7yfgCBAzt3lQEO1cXdMOS8is9AqhQMj1TgXyzTpWwLe JYh5n1wrZmz7+S4wC1lJqQdv X-Google-Smtp-Source: AA6agR5GiSlxh2cmlWyeDiHHjzxfvaCgZ9HYTvYeOKAiYpTa/s1YAOHFRmxWKcrx16+h4JnQNfJcjg== X-Received: by 2002:a17:90a:4805:b0:1f5:39ab:29a9 with SMTP id a5-20020a17090a480500b001f539ab29a9mr12901550pjh.202.1659805084471; Sat, 06 Aug 2022 09:58:04 -0700 (PDT) Received: from thinkpad ([117.202.188.20]) by smtp.gmail.com with ESMTPSA id y1-20020a17090322c100b0016d93c84049sm5347778plg.54.2022.08.06.09.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 09:58:04 -0700 (PDT) Date: Sat, 6 Aug 2022 22:27:58 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config Message-ID: <20220806165758.GR14384@thinkpad> References: <20220805092317.4985-1-johan+linaro@kernel.org> <20220805092317.4985-6-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220805092317.4985-6-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2022 at 11:23:15AM +0200, Johan Hovold wrote: > The HID pin configurations belong in the HID nodes rather than i2c bus > node. > > Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 85efce641a4e..76ba2d5fa17e 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -177,7 +177,7 @@ &qup0_i2c4 { > clock-frequency = <400000>; > > pinctrl-names = "default"; > - pinctrl-0 = <&qup0_i2c4_default>, <&ts0_default>; > + pinctrl-0 = <&qup0_i2c4_default>; > > status = "okay"; > > @@ -185,9 +185,13 @@ &qup0_i2c4 { > touchscreen@10 { > compatible = "hid-over-i2c"; > reg = <0x10>; > + > hid-descr-addr = <0x1>; > interrupts-extended = <&tlmm 175 IRQ_TYPE_LEVEL_LOW>; > vdd-supply = <&vreg_misc_3p3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ts0_default>; > }; > }; > > @@ -203,24 +207,32 @@ &qup2_i2c5 { > clock-frequency = <400000>; > > pinctrl-names = "default"; > - pinctrl-0 = <&qup2_i2c5_default>, <&kybd_default>, <&tpad_default>; > + pinctrl-0 = <&qup2_i2c5_default>; > > status = "okay"; > > touchpad@2c { > compatible = "hid-over-i2c"; > reg = <0x2c>; > + > hid-descr-addr = <0x20>; > interrupts-extended = <&tlmm 182 IRQ_TYPE_LEVEL_LOW>; > vdd-supply = <&vreg_misc_3p3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&tpad_default>; > }; > > keyboard@68 { > compatible = "hid-over-i2c"; > reg = <0x68>; > + > hid-descr-addr = <0x1>; > interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; > vdd-supply = <&vreg_misc_3p3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&kybd_default>; > }; > }; > > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்