From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C614AC00140 for ; Mon, 8 Aug 2022 07:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242010AbiHHH5B (ORCPT ); Mon, 8 Aug 2022 03:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237465AbiHHH4z (ORCPT ); Mon, 8 Aug 2022 03:56:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DA3E6647D for ; Mon, 8 Aug 2022 00:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659945413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AufWZZEcgThI2xBgpMKruzYOgK1FWSrmvzjD3Nvo93Q=; b=eXrpzcFNeKJyXiMp/MNVkHl1qDSMsi6nmvvDa8TeGkCZfVN2KwfoEBeRuS9TG+vAuXeBAr xyXUacIJxHu854n1Q3WLMREY3GHLA2UoO9m88PIOi8AEmJBcFhH5fiDK4cz5WK2gZ00UEW I93HBcLngCm7Opp8p+6iY58BxK00gFM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-541-RT4HmJZpPVqaUHQdBSZTRQ-1; Mon, 08 Aug 2022 03:56:50 -0400 X-MC-Unique: RT4HmJZpPVqaUHQdBSZTRQ-1 Received: by mail-qv1-f72.google.com with SMTP id nm18-20020a0562143b1200b0047b33c1e57eso1567643qvb.10 for ; Mon, 08 Aug 2022 00:56:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=AufWZZEcgThI2xBgpMKruzYOgK1FWSrmvzjD3Nvo93Q=; b=Le/pIC09Z2U0dDDm8L0yw2bNMTMZPncbFh+WE4/tGvXAI9AeCWRr6C/m/WyFdBEb93 QMQ4aJJ4RhMf1TzWlOHA2R8xRJ0tPhir7GJWSh4BvRc+zgKFqV/aQUep8NZQDIX6Djz+ U1+oEbYNQZ+SCohO0FrML7cggljQMscbXL0/G7A3QRNoQ2l/vd/5XaS4y/VA2b8W2IRl u53XVzTobkJYMlIgbgYOm3NNbAn15ahW87TPfxkIqPEtd8CtO1khVzr+85R7AaNOmj85 BEhK0LRZVfnDXIUnmwoARQcAmpKjAHwdcScwqWNcrD81opS9EVw8xJClkvnjJRxrHrap bksg== X-Gm-Message-State: ACgBeo1IgScem1s+fEXlG3q2idms+0FcO5tk37C8pC0XXc4CSbP2AqJp kzV3/nNssCvlzMKuJZG3gY0G3hid61itmsjwBiCI8IvNm/oaiH6z3ZoE/aCheV42MlTAzZ/wRIF XlteCCOdSWVdSVM3KH8XJtUft X-Received: by 2002:a05:620a:2b8b:b0:6b9:43ca:4a6 with SMTP id dz11-20020a05620a2b8b00b006b943ca04a6mr3566713qkb.346.1659945409702; Mon, 08 Aug 2022 00:56:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR5AHQLL6/c6cBtSoanSesmnPrpZdXyxLWrWNaQRi8fOEBNqs018hbyfcdBhlapIkl42VoQl4w== X-Received: by 2002:a05:620a:2b8b:b0:6b9:43ca:4a6 with SMTP id dz11-20020a05620a2b8b00b006b943ca04a6mr3566697qkb.346.1659945409523; Mon, 08 Aug 2022 00:56:49 -0700 (PDT) Received: from sgarzare-redhat (host-79-46-200-178.retail.telecomitalia.it. [79.46.200.178]) by smtp.gmail.com with ESMTPSA id b16-20020a05622a021000b0031eddc83560sm7421933qtx.90.2022.08.08.00.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 00:56:48 -0700 (PDT) Date: Mon, 8 Aug 2022 09:56:40 +0200 From: Stefano Garzarella To: Peilin Ye Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peilin Ye , George Zhang , Dmitry Torokhov , Andy King , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 2/2] vsock: Set socket state back to SS_UNCONNECTED in vsock_connect_timeout() Message-ID: <20220808075640.5it462iozqgecxih@sgarzare-redhat> References: <5cf1337b4f6e82bc0a4eb0bef422a53dcc9d584a.1659862577.git.peilin.ye@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5cf1337b4f6e82bc0a4eb0bef422a53dcc9d584a.1659862577.git.peilin.ye@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 07, 2022 at 02:00:46AM -0700, Peilin Ye wrote: >From: Peilin Ye > >Imagine two non-blocking vsock_connect() requests on the same socket. >The first request schedules @connect_work, and after it times out, >vsock_connect_timeout() sets *sock* state back to TCP_CLOSE, but keeps >*socket* state as SS_CONNECTING. > >Later, the second request returns -EALREADY, meaning the socket "already >has a pending connection in progress", even if the first request has >already timed out. > >As suggested by Stefano, fix it by setting *socket* state back to >SS_UNCONNECTED, so that the second request will return -ETIMEDOUT. > >Suggested-by: Stefano Garzarella >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Signed-off-by: Peilin Ye >--- >(new patch in v2) Thanks for sending this :-) Reviewed-by: Stefano Garzarella