From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB9BC25B06 for ; Mon, 8 Aug 2022 10:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237420AbiHHKyD (ORCPT ); Mon, 8 Aug 2022 06:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234608AbiHHKyA (ORCPT ); Mon, 8 Aug 2022 06:54:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 03867189 for ; Mon, 8 Aug 2022 03:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659956038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cqTZfTOpSZv/oxvZyQIT3dmO6v6DeAZnUAfnA5NVFOM=; b=hgAr4wdAB7n99/kjR2gXD1uCd/g3qvycybsjMOwW6aQokcGIIMuvMepWI3tLEupgorQSX0 zNako5IxOKOJSucEq3e3MFRlZ53ho25bdempIFgbGJnCcCkPb11BpG24oHBO2pCtNad4PF fqo3kuv/HuNlvEqpdnmlQq9nbFVo654= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-602-rDxJh4YCNpCaihN57TBSEw-1; Mon, 08 Aug 2022 06:53:57 -0400 X-MC-Unique: rDxJh4YCNpCaihN57TBSEw-1 Received: by mail-qk1-f199.google.com with SMTP id bp14-20020a05620a458e00b006b959ef9d51so1306185qkb.12 for ; Mon, 08 Aug 2022 03:53:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=cqTZfTOpSZv/oxvZyQIT3dmO6v6DeAZnUAfnA5NVFOM=; b=viEVTSd624UrNKxxdKLHLZ8ID+oblfmXnPvnJ4y2r/VuetTYGBGJT7+smxZYbY0xWY pVx8aSTna/jGEmWBwhRQfqhXiaoQmWNAGmz2Nu8aj0ovNbRi120o2oxrKvhx8UPg2PNF mSXszU/wMRQJ/0Bi5LBQ5sIW0LYF6GLX7ZvyMSTUI6ilK33nAl39TqhgqVRqciiGMgHH XyMe+U5VkUFuvlotUmtCv/3ExoTRGKN6AoVX315hrweuLchzJb34l7PaVvpM8+Jx6Ewz LJV4WUrxYj374FnagUGySUP56VyBJJXEjZYaCgiZfu99MIvsxkEWYn6hrkYOSYsOZWwV RFhA== X-Gm-Message-State: ACgBeo3+if4w0CfMD8ihgSTuJ0AUkwH4K/Y5MreN+J6ohccfAYLyLUJu ckNpliGGcQKnG9/x02h6blJGDYl4jpVS06/jrXLjOBQULZ4fm/TLf5alIfwj5OCN6iBIVUSfYiN mMwxvJNpYPpCKQcSaN0wFLg5b X-Received: by 2002:a05:620a:f8f:b0:6b5:be6c:255e with SMTP id b15-20020a05620a0f8f00b006b5be6c255emr13571452qkn.638.1659956036589; Mon, 08 Aug 2022 03:53:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR5eZOYkfnMEABqPmnzlbZTfqIBNY9uF7dpmoPWJ7+Uc8TBxra/Vn+m6r3fobIYoBwsf4CHA7A== X-Received: by 2002:a05:620a:f8f:b0:6b5:be6c:255e with SMTP id b15-20020a05620a0f8f00b006b5be6c255emr13571431qkn.638.1659956036378; Mon, 08 Aug 2022 03:53:56 -0700 (PDT) Received: from sgarzare-redhat (host-79-46-200-178.retail.telecomitalia.it. [79.46.200.178]) by smtp.gmail.com with ESMTPSA id az38-20020a05620a172600b006b8619a67f4sm8787400qkb.34.2022.08.08.03.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 03:53:55 -0700 (PDT) Date: Mon, 8 Aug 2022 12:53:45 +0200 From: Stefano Garzarella To: Arseniy Krasnov Cc: "David S. Miller" , "edumazet@google.com" , Jakub Kicinski , Paolo Abeni , "kys@microsoft.com" , "haiyangz@microsoft.com" , "sthemmin@microsoft.com" , "wei.liu@kernel.org" , Dexuan Cui , Stefan Hajnoczi , Bryan Tan , Vishnu Dasa , VMware PV-Drivers Reviewers , Krasnov Arseniy , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , kernel Subject: Re: [RFC PATCH v3 6/9] vsock: add API call for data ready Message-ID: <20220808105345.vm7x6nzbi4ss7v6j@sgarzare-redhat> References: <2ac35e2c-26a8-6f6d-2236-c4692600db9e@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2022 at 02:01:57PM +0000, Arseniy Krasnov wrote: >This adds 'vsock_data_ready()' which must be called by transport to kick >sleeping data readers. It checks for SO_RCVLOWAT value before waking >user,thus preventing spurious wake ups.Based on 'tcp_data_ready()' logic. > Since it's an RFC, I suggest you add a space after the punctuation. :-) The patch LGTM: Reviewed-by: Stefano Garzarella >Signed-off-by: Arseniy Krasnov >--- > include/net/af_vsock.h | 1 + > net/vmw_vsock/af_vsock.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > >diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h >index eae5874bae35..7b79fc5164cc 100644 >--- a/include/net/af_vsock.h >+++ b/include/net/af_vsock.h >@@ -77,6 +77,7 @@ struct vsock_sock { > s64 vsock_stream_has_data(struct vsock_sock *vsk); > s64 vsock_stream_has_space(struct vsock_sock *vsk); > struct sock *vsock_create_connected(struct sock *parent); >+void vsock_data_ready(struct sock *sk); > > /**** TRANSPORT ****/ > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 3a1426eb8baa..47e80a7cbbdf 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -882,6 +882,16 @@ s64 vsock_stream_has_space(struct vsock_sock *vsk) > } > EXPORT_SYMBOL_GPL(vsock_stream_has_space); > >+void vsock_data_ready(struct sock *sk) >+{ >+ struct vsock_sock *vsk = vsock_sk(sk); >+ >+ if (vsock_stream_has_data(vsk) >= sk->sk_rcvlowat || >+ sock_flag(sk, SOCK_DONE)) >+ sk->sk_data_ready(sk); >+} >+EXPORT_SYMBOL_GPL(vsock_data_ready); >+ > static int vsock_release(struct socket *sock) > { > __vsock_release(sock->sk, 0); >-- >2.25.1