From: Aleksey Romanov <AVRomanov@sberdevices.ru>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
"minchan@kernel.org" <minchan@kernel.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"ngupta@vflare.org" <ngupta@vflare.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@chromium.org" <axboe@chromium.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mnitenko@gmail.com" <mnitenko@gmail.com>,
Dmitry Rokosov <DDRokosov@sberdevices.ru>
Subject: Re: [PATCH v5] zram: remove double compression logic
Date: Tue, 9 Aug 2022 13:06:19 +0000 [thread overview]
Message-ID: <20220809130543.4dnh5aa3kdxbmzje@cab-wsm-0029881.sigma.sbrf.ru> (raw)
In-Reply-To: <YvJV8rU9bkqiy9iA@google.com>
Hi Sergey,
On Tue, Aug 09, 2022 at 09:41:22PM +0900, Sergey Senozhatsky wrote:
> On (22/05/05 12:44), Alexey Romanov wrote:
> > @@ -1975,7 +1954,6 @@ static int zram_add(void)
> > if (ZRAM_LOGICAL_BLOCK_SIZE == PAGE_SIZE)
> > blk_queue_max_write_zeroes_sectors(zram->disk->queue, UINT_MAX);
> >
> > - blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, zram->disk->queue);
>
> By the way, why did it remove QUEUE_FLAG_STABLE_WRITES bit?
Minchan asked me to add this change and this description:
"Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
buffer change between 1st and 2nd memory allocations. Since we remove
second trial memory allocation logic, we could remove the STABLE_WRITES
flag because there is no change buffer to be modified under us"
This seems to be logical.
--
Thank you,
Alexey
prev parent reply other threads:[~2022-08-09 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 9:44 [PATCH v5] zram: remove double compression logic Alexey Romanov
2022-05-05 16:57 ` Minchan Kim
2022-08-09 12:41 ` Sergey Senozhatsky
2022-08-09 13:06 ` Aleksey Romanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809130543.4dnh5aa3kdxbmzje@cab-wsm-0029881.sigma.sbrf.ru \
--to=avromanov@sberdevices.ru \
--cc=DDRokosov@sberdevices.ru \
--cc=akpm@linux-foundation.org \
--cc=axboe@chromium.org \
--cc=kernel@sberdevices.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mnitenko@gmail.com \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).