From: Nico Pache <npache@redhat.com>
To: kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, davidgow@google.com
Cc: skhan@linuxfoundation.org, dlatypov@google.com,
brendan.higgins@linux.dev, alcioa@amazon.com, lexnv@amazon.com,
andraprs@amazon.com, YehezkelShB@gmail.com,
mika.westerberg@linux.intel.com, michael.jamet@intel.com,
andreas.noever@gmail.com
Subject: [PATCH] kunit: fix Kconfig for build-in tests USB4 and Nitro Enclaves
Date: Wed, 10 Aug 2022 19:40:56 -0400 [thread overview]
Message-ID: <20220810234056.2494993-1-npache@redhat.com> (raw)
Both the USB4 and Nitro Enclaves KUNIT tests are now able to be compiled
if KUNIT is compiled as a module. This leads to issues if KUNIT is being
packaged separately from the core kernel and when KUNIT is run baremetal
without the required driver compiled into the kernel.
Fixes: 635dcd16844b ("thunderbolt: test: Use kunit_test_suite() macro")
Fixes: fe5be808fa6c ("nitro_enclaves: test: Use kunit_test_suite() macro")
Signed-off-by: Nico Pache <npache@redhat.com>
---
drivers/thunderbolt/Kconfig | 3 +--
drivers/virt/nitro_enclaves/Kconfig | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index e76a6c173637..f12d0a3ee3e2 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -29,8 +29,7 @@ config USB4_DEBUGFS_WRITE
config USB4_KUNIT_TEST
bool "KUnit tests" if !KUNIT_ALL_TESTS
- depends on (USB4=m || KUNIT=y)
- depends on KUNIT
+ depends on USB4 && KUNIT=y
default KUNIT_ALL_TESTS
config USB4_DMA_TEST
diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
index ce91add81401..dc4d25c26256 100644
--- a/drivers/virt/nitro_enclaves/Kconfig
+++ b/drivers/virt/nitro_enclaves/Kconfig
@@ -17,7 +17,7 @@ config NITRO_ENCLAVES
config NITRO_ENCLAVES_MISC_DEV_TEST
bool "Tests for the misc device functionality of the Nitro Enclaves" if !KUNIT_ALL_TESTS
- depends on NITRO_ENCLAVES && KUNIT
+ depends on NITRO_ENCLAVES && KUNIT=y
default KUNIT_ALL_TESTS
help
Enable KUnit tests for the misc device functionality of the Nitro
--
2.36.1
next reply other threads:[~2022-08-10 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 23:40 Nico Pache [this message]
2022-08-11 0:19 ` [PATCH] kunit: fix Kconfig for build-in tests USB4 and Nitro Enclaves David Gow
2022-08-11 12:43 ` Nico Pache
2022-08-12 6:43 ` David Gow
2022-08-12 16:15 ` Joe Fradley
2022-08-13 12:40 ` Nico Pache
2022-08-13 12:03 ` Nico Pache
2022-08-12 6:47 ` David Gow
2022-08-15 5:44 ` Paraschiv, Andra-Irina
2022-08-29 22:49 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810234056.2494993-1-npache@redhat.com \
--to=npache@redhat.com \
--cc=YehezkelShB@gmail.com \
--cc=alcioa@amazon.com \
--cc=andraprs@amazon.com \
--cc=andreas.noever@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=lexnv@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).