From: Jia He <justin.he@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Robert Moore <robert.moore@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, devel@acpica.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-efi@vger.kernel.org, nd@arm.com, toshi.kani@hpe.com,
Jia He <justin.he@arm.com>
Subject: [PATCH 0/2] Modularize ghes_edac driver
Date: Thu, 11 Aug 2022 09:17:11 +0000 [thread overview]
Message-ID: <20220811091713.10427-1-justin.he@arm.com> (raw)
Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in
apci_init()") introduced a bug that ghes_edac_register() would be invoked
before edac_init(). Because at that time, the bus "edac" hasn't been even
registered, this created sysfs /devices/mc0 instead of
/sys/devices/system/edac/mc/mc0 on an Ampere eMag server.
The solution is modularizing the ghes_edac driver.
I tested the cases as follows:
1. build test with ghes_edac built-in and module on Aarch64
2. build test with ghes_edac built-in and module on x86_64
3. boot test with ghes_edac built-in and module on Aarch64
4. modprobe and -r for multiple times on Aarch64.
Jia He (2):
efi/cper: export several helpers for ghes edac to use
EDAC/ghes: Modularize ghes_edac driver to remove the dependency on
ghes
drivers/acpi/apei/ghes.c | 49 ++++++++++++++++++++++--
drivers/edac/Kconfig | 4 +-
drivers/edac/ghes_edac.c | 74 ++++++++++++++++++++++++++-----------
drivers/firmware/efi/cper.c | 3 ++
include/acpi/ghes.h | 33 ++++-------------
5 files changed, 110 insertions(+), 53 deletions(-)
--
2.25.1
next reply other threads:[~2022-08-11 9:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:17 Jia He [this message]
2022-08-11 9:17 ` [PATCH 1/2] efi/cper: export several helpers for ghes edac to use Jia He
2022-08-11 15:07 ` Ard Biesheuvel
2022-08-12 14:46 ` Borislav Petkov
2022-08-15 1:13 ` Justin He
2022-08-11 9:17 ` [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Jia He
2022-08-11 19:26 ` Kani, Toshi
2022-08-12 10:58 ` kernel test robot
2022-08-12 14:46 ` Borislav Petkov
2022-08-15 1:32 ` Justin He
2022-08-17 8:36 ` Borislav Petkov
2022-08-16 2:20 ` Justin He
2022-08-17 1:39 ` Kani, Toshi
2022-08-17 8:50 ` Borislav Petkov
2022-08-17 20:22 ` Kani, Toshi
2022-08-17 20:56 ` Borislav Petkov
2022-08-17 21:09 ` Kani, Toshi
2022-08-17 21:34 ` Borislav Petkov
2022-08-18 1:24 ` Justin He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811091713.10427-1-justin.he@arm.com \
--to=justin.he@arm.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=devel@acpica.org \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nd@arm.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).