From: ira.weiny@intel.com
To: Kees Cook <keescook@chromium.org>
Cc: Ira Weiny <ira.weiny@intel.com>,
syzbot+3250d9c8925ef29e975f@syzkaller.appspotmail.com,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
ebiederm@xmission.com, viro@zeniv.linux.org.uk,
sfr@canb.auug.org.au, syzkaller-bugs@googlegroups.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] fs/exec: Test patch for syzkaller crash
Date: Thu, 11 Aug 2022 17:09:19 -0700 [thread overview]
Message-ID: <20220812000919.408614-1-ira.weiny@intel.com> (raw)
From: Ira Weiny <ira.weiny@intel.com>
Kees reported that it looked like the kmap_local_page() conversion in
fs/exec.c was causing a crash with the syzkaller.[1]
At first glance it appeared this was due to the lack of pagefaults not
being disabled as was done by kmap_atomic().
Unfortunately, after deeper investigation we don't see how this is a
problem. The crash does not appear to be happening in the
memcpy_to_page() call.[2]
For testing, add back pagefault disable in copy_string_kernel() to see
if it makes syzkaller happy. If so more investigation will need to be
done to understand exactly what is happening.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6e8e36c6ae4b11bed5643317afb66b6c3cadba8
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/exec.c?id=40d43a7507e1547dd45cb02af2e40d897c591870#n616
Cc: Kees Cook <keescook@chromium.org>
Reported-by: syzbot+3250d9c8925ef29e975f@syzkaller.appspotmail.com
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
fs/exec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/exec.c b/fs/exec.c
index b51dd14e7388..e076b228123a 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -640,7 +640,9 @@ int copy_string_kernel(const char *arg, struct linux_binprm *bprm)
if (!page)
return -E2BIG;
flush_arg_page(bprm, pos & PAGE_MASK, page);
+ pagefault_disable();
memcpy_to_page(page, offset_in_page(pos), arg, bytes_to_copy);
+ pagefault_enable();
put_arg_page(page);
}
--
2.35.3
next reply other threads:[~2022-08-12 0:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 0:09 ira.weiny [this message]
2022-08-12 18:45 ` [PATCH] fs/exec: Test patch for syzkaller crash Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812000919.408614-1-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=ebiederm@xmission.com \
--cc=fmdefrancesco@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=syzbot+3250d9c8925ef29e975f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).