From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62704C25B06 for ; Sun, 14 Aug 2022 15:55:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242254AbiHNPy7 (ORCPT ); Sun, 14 Aug 2022 11:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242019AbiHNPu4 (ORCPT ); Sun, 14 Aug 2022 11:50:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EA4919283; Sun, 14 Aug 2022 08:36:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6C8FB80B56; Sun, 14 Aug 2022 15:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 769F3C43470; Sun, 14 Aug 2022 15:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660491388; bh=zCjPwheLub6dsDGmASzjdfqqFdiCv1VVXqIVLu32/tE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OAHHfXDORCNgCqsoQhfOfhoajoe2bUxjbF4Uqpipq8IAmXGTPPhpZq0/2ihsGGWhu Haosb6EzM38MWW7fb2L8Ylw+eds8zwFRX+FF7kYwhypcTXEoKhNIo/FK+1OYFAPLjl w1BRC48AYnaJ0XzlU3y9wD/FBfvk8VABMovL9dk/VXgil3UALLtVg2ReGxfmcQTKSu 0uBoh3EEkXFzF5FaZ4rpQZzR7uMfFC7bk6ZyejtTulvtIjMhGdCPkuvPb46hEwTyB1 XnLIbaS062bL4jq4tQE/l/16z1e0uIzDCJEKDibZBxlkcda0FuQbvhDrE/C3czlC2h vPx68wdTuZYNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Baolin Wang , Vinod Koul , Sasha Levin , orsonzhai@gmail.com, zhang.lyra@gmail.com, dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/13] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed Date: Sun, 14 Aug 2022 11:36:06 -0400 Message-Id: <20220814153610.2380234-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220814153610.2380234-1-sashal@kernel.org> References: <20220814153610.2380234-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König [ Upstream commit 1e42f82cbec7b2cc4873751e7791e6611901c5fc ] It's not allowed to quit remove early without cleaning up completely. Otherwise this results in resource leaks that probably yield graver problems later. Here for example some tasklets might survive the lifetime of the sprd-dma device and access sdev which is freed after .remove() returns. As none of the device freeing requires an active device, just ignore the return value of pm_runtime_get_sync(). Signed-off-by: Uwe Kleine-König Reviewed-by: Baolin Wang Link: https://lore.kernel.org/r/20220721204054.323602-1-u.kleine-koenig@pengutronix.de Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/sprd-dma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 0fadf6a08494..4ec9a924a338 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -987,11 +987,8 @@ static int sprd_dma_remove(struct platform_device *pdev) { struct sprd_dma_dev *sdev = platform_get_drvdata(pdev); struct sprd_dma_chn *c, *cn; - int ret; - ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) - return ret; + pm_runtime_get_sync(&pdev->dev); /* explicitly free the irq */ if (sdev->irq > 0) -- 2.35.1