From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5DDC25B06 for ; Sun, 14 Aug 2022 16:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243280AbiHNQnW (ORCPT ); Sun, 14 Aug 2022 12:43:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243271AbiHNQkd (ORCPT ); Sun, 14 Aug 2022 12:40:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B301B64E9; Sun, 14 Aug 2022 09:30:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52CD860FBF; Sun, 14 Aug 2022 16:30:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05BD1C433C1; Sun, 14 Aug 2022 16:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660494651; bh=/tKUeDNsWC4TjtU5BAtVdURhSCpADm0fbCBQrx2Hg4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GC+fr5tZ3NOFel+eaoE9Ped8wHEC2DXtdDXpEg8wsycHtifmp0cmDJho4vpuGGqU0 RXk/ZgXc6buwHA/CKVELT5gOm0ZbEbMGUMrLhzz4q6HuVLa9da+hxJ50UT5TeFTwCS btt7DisyFYACFraqB0Mwx62GDqtxan85/RC2mWJcluKRMGAIIOZYIb50WRORitZl4r 3VocHBrA/l+jWJnZfY5bbLMvPrDjVaheYTmNl2u9sptuRTds90I1e0IBeSDh4b4X2R yrpH7fq8ddArChHL87nbbGLC4Mhf7aOUzYfgnSiTok3o+NlobOblHZy/cGn2KGOZni RdypZkXTMc1xw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , ye.guojin@zte.com.cn, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 3/8] mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start Date: Sun, 14 Aug 2022 12:30:36 -0400 Message-Id: <20220814163041.2399552-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220814163041.2399552-1-sashal@kernel.org> References: <20220814163041.2399552-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He [ Upstream commit 7a9f743ceead60ed454c46fbc3085ee9a79cbebb ] We should call of_node_put() for the reference 'uctl_node' returned by of_get_parent() which will increase the refcount. Otherwise, there will be a refcount leak bug. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/cavium-octeon/octeon-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c index 2ecc8d1b0539..f295be876390 100644 --- a/arch/mips/cavium-octeon/octeon-platform.c +++ b/arch/mips/cavium-octeon/octeon-platform.c @@ -130,11 +130,12 @@ static void octeon2_usb_clocks_start(struct device *dev) "refclk-frequency", &clock_rate); if (i) { dev_err(dev, "No UCTL \"refclk-frequency\"\n"); + of_node_put(uctl_node); goto exit; } i = of_property_read_string(uctl_node, "refclk-type", &clock_type); - + of_node_put(uctl_node); if (!i && strcmp("crystal", clock_type) == 0) is_crystal_clock = true; } -- 2.35.1