From: kernel test robot <lkp@intel.com>
To: lewis.hanly@microchip.com, linux-gpio@vger.kernel.org,
linux-riscv@lists.infradead.org, linus.walleij@linaro.org,
brgl@bgdev.pl, linux-kernel@vger.kernel.org, palmer@dabbelt.com,
maz@kernel.org
Cc: kbuild-all@lists.01.org, conor.dooley@microchip.com,
daire.mcnamara@microchip.com, lewis.hanly@microchip.com
Subject: Re: [PATCH v5 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Mon, 15 Aug 2022 19:39:35 +0800 [thread overview]
Message-ID: <202208151906.8v7FxH3X-lkp@intel.com> (raw)
In-Reply-To: <20220815070606.1298421-2-lewis.hanly@microchip.com>
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on linus/master v6.0-rc1 next-20220815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220815-150808
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220815/202208151906.8v7FxH3X-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0458963d9f39d68b20ed88e71d20ca69d835e7fe
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220815-150808
git checkout 0458963d9f39d68b20ed88e71d20ca69d835e7fe
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpio/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_irq_handler':
drivers/gpio/gpio-mpfs.c:203:9: error: 'unisgned' undeclared (first use in this function)
203 | unisgned long status;
| ^~~~~~~~
drivers/gpio/gpio-mpfs.c:203:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpio/gpio-mpfs.c:203:17: error: expected ';' before 'long'
203 | unisgned long status;
| ^~~~~
| ;
>> drivers/gpio/gpio-mpfs.c:204:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
204 | int offset;
| ^~~
drivers/gpio/gpio-mpfs.c:208:9: error: 'status' undeclared (first use in this function); did you mean 'kstatfs'?
208 | status = readl(mpfs_gpio->base + MPFS_IRQ_REG);
| ^~~~~~
| kstatfs
drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_probe':
drivers/gpio/gpio-mpfs.c:268:19: error: 'struct irq_chip' has no member named 'parent_device'
268 | girq->chip->parent_device = dev;
| ^~
vim +204 drivers/gpio/gpio-mpfs.c
197
198 static void mpfs_gpio_irq_handler(struct irq_desc *desc)
199 {
200 struct irq_chip *irqchip = irq_desc_get_chip(desc);
201 struct mpfs_gpio_chip *mpfs_gpio =
202 gpiochip_get_data(irq_desc_get_handler_data(desc));
> 203 unisgned long status;
> 204 int offset;
205
206 chained_irq_enter(irqchip, desc);
207
208 status = readl(mpfs_gpio->base + MPFS_IRQ_REG);
209 for_each_set_bit(offset, &status, mpfs_gpio->gc.ngpio) {
210 mpfs_gpio_assign_bit(mpfs_gpio->base + MPFS_IRQ_REG, offset, 1);
211 generic_handle_irq(irq_find_mapping(mpfs_gpio->gc.irq.domain, offset));
212 }
213
214 chained_irq_exit(irqchip, desc);
215 }
216
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-08-15 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 7:06 [PATCH v5 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-08-15 7:06 ` [PATCH v5 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-08-15 7:38 ` Christophe JAILLET
2022-08-15 12:04 ` Lewis.Hanly
2022-08-15 11:39 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208151906.8v7FxH3X-lkp@intel.com \
--to=lkp@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=kbuild-all@lists.01.org \
--cc=lewis.hanly@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).