From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F96CC00140 for ; Tue, 16 Aug 2022 01:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241455AbiHPBTV (ORCPT ); Mon, 15 Aug 2022 21:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233520AbiHPBS6 (ORCPT ); Mon, 15 Aug 2022 21:18:58 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43E6458099; Mon, 15 Aug 2022 14:10:54 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 12D0C32002D8; Mon, 15 Aug 2022 17:10:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 17:10:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1660597837; x=1660684237; bh=9d7dhCe3Fq d/bfA8yD544NDBFEKnJIxJgepP6HupnHc=; b=Sw2GBTR4vuywnmfbU2VucVwN4b efRwLx92+SeVxu9DpYiM9sS9H38X+M9nmB2XpzhNvOxxb5JoJDbTxawwkLvyk2c3 buevRKZhBacx0DwC2+uAC/LsFPKBO76ez0raPhNZoceUAslgZH4W2rO7xZmFFmtt NV3qcTcxQFLYsWMFvy4tzaHbZYJ6Vt2/wj/Sta4FHeb65rISF4i+p9Tv4zpDkP8A NK+lS5/hOGiOxGACwReToCSic0km/wxhPXT7vfwCUeCdbIMCQ8wgCnkZn78PLK9o +pcAZ9QUkGDWP5Mvnob0xP2ktcIZkVN7CKZAoof0l396WC6OVXZHaU/q840Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660597837; x=1660684237; bh=9d7dhCe3Fqd/bfA8yD544NDBFEKn JIxJgepP6HupnHc=; b=KOJlnqL03kLLyaO/0NB3mk/dJoirnU68Nx7JTKUpj8rf vVe7p792KJXBC1XDT+m4D2XgZDLPBhNoR4xTIgMVHlR6yfvZ3QIQsgWhIqzQ44V8 PUSEk7w8PQAn/cFwQq+u3nktOgacR/uZ+f/6/FbpnfDILGqmlI1I8po77UZvWuG2 wg6vQMgkdVeECgU1fuw5SKVQh+x1HHTMdqhw/Ae0XBcAIi4nLfb24x4PrqZt2H83 JWa0oWlIGniGkDoc2Y1SnLtkyK6JXlFGoKLWA1QB5a6CrDmNS4mJ6vX5P2Yl+I/+ v5EOExxCTEDkGcg3t8qDwfwwukD2UeOcM6FCEGo6gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehvddgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 17:10:36 -0400 (EDT) Date: Mon, 15 Aug 2022 14:10:35 -0700 From: Andres Freund To: "Michael S. Tsirkin" Cc: Xuan Zhuo , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Linus Torvalds , Jens Axboe , James Bottomley , "Martin K. Petersen" , Guenter Roeck , linux-kernel@vger.kernel.org, Greg KH , c@redhat.com Subject: Re: upstream kernel crashes Message-ID: <20220815211035.r2ojxkilwsbxyewu@awork3.anarazel.de> References: <20220815081527.soikyi365azh5qpu@awork3.anarazel.de> <20220815042623-mutt-send-email-mst@kernel.org> <20220815113729-mutt-send-email-mst@kernel.org> <20220815164503.jsoezxcm6q4u2b6j@awork3.anarazel.de> <20220815124748-mutt-send-email-mst@kernel.org> <20220815174617.z4chnftzcbv6frqr@awork3.anarazel.de> <20220815161423-mutt-send-email-mst@kernel.org> <20220815205330.m54g7vcs77r6owd6@awork3.anarazel.de> <20220815210437.saptyw6clr7datun@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220815210437.saptyw6clr7datun@awork3.anarazel.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2022-08-15 14:04:37 -0700, Andres Freund wrote: > Booting with the equivalent change, atop 5.19, in the legacy setup_vq() > reliably causes boot to hang: I don't know much virtio, so take this with a rock of salt: Legacy setup_vq() doesn't tell the host about the queue size. The modern one does: vp_modern_set_queue_size(mdev, index, virtqueue_get_vring_size(vq)); but the legacy one doesn't. I assume this means the host will assume the queue is of the size suggested by vp_legacy_get_queue_size(). If the host continues to write into the space after the "assumed end" of the queue, but the guest puts other stuff in that space, well, I'd expect fun roughly like the stuff we've been seeing in this and related threads. Greetings, Andres Freund