From: Rob Herring <robh@kernel.org>
To: Irui Wang <irui.wang@mediatek.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tzung-Bi Shih <tzungbi@chromium.org>,
angelogioacchino.delregno@collabora.com,
nicolas.dufresne@collabora.com, wenst@chromium.org,
kyrie wu <kyrie.wu@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Tomasz Figa <tfiga@chromium.org>,
xia.jiang@mediatek.com, maoguang.meng@mediatek.com
Subject: Re: [V12,1/7] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible
Date: Tue, 16 Aug 2022 10:27:00 -0600 [thread overview]
Message-ID: <20220816162700.GA2325543-robh@kernel.org> (raw)
In-Reply-To: <20220729062630.5592-2-irui.wang@mediatek.com>
On Fri, Jul 29, 2022 at 02:26:24PM +0800, Irui Wang wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Add mediatek,mt8195-jpgenc compatible to binding document.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> Signed-off-by: irui wang <irui.wang@mediatek.com>
> ---
> .../media/mediatek,mt8195-jpegenc.yaml | 139 ++++++++++++++++++
> 1 file changed, 139 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> new file mode 100644
> index 000000000000..d9133e6a92f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> @@ -0,0 +1,139 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegenc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek JPEG Encoder Device Tree Bindings
> +
> +maintainers:
> + - kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>
> +
> +description:
> + MediaTek JPEG Encoder is the JPEG encode hardware present in MediaTek SoCs
> +
> +properties:
> + compatible:
> + items:
> + - const: mediatek,mt8195-jpgenc
> +
> + power-domains:
> + maxItems: 1
> +
> + iommus:
> + maxItems: 4
> + description:
> + Points to the respective IOMMU block with master port as argument, see
> + Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
> + Ports are according to the HW.
> +
> + "#address-cells":
> + const: 2
> +
> + "#size-cells":
> + const: 2
> +
> + ranges: true
> +
> +# Required child node:
> +patternProperties:
> + "^jpgenc@[0-9a-f]+$":
> + type: object
> + description:
> + The jpeg encoder hardware device node which should be added as subnodes to
> + the main jpeg node.
> +
> + properties:
> + compatible:
> + const: mediatek,mt8195-jpgenc-hw
> +
> + reg:
> + maxItems: 1
> +
> + iommus:
> + minItems: 1
> + maxItems: 32
> + description:
> + List of the hardware port in respective IOMMU block for current Socs.
> + Refer to bindings/iommu/mediatek,iommu.yaml.
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: jpgenc
> +
> + power-domains:
> + maxItems: 1
> +
> + required:
> + - compatible
> + - reg
> + - iommus
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - power-domains
> + - iommus
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/memory/mt8195-memory-port.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + jpgenc_master {
> + compatible = "mediatek,mt8195-jpgenc";
> + power-domains = <&spm MT8195_POWER_DOMAIN_VENC_CORE1>;
> + iommus = <&iommu_vpp M4U_PORT_L20_JPGENC_Y_RDMA>,
> + <&iommu_vpp M4U_PORT_L20_JPGENC_C_RDMA>,
> + <&iommu_vpp M4U_PORT_L20_JPGENC_Q_TABLE>,
> + <&iommu_vpp M4U_PORT_L20_JPGENC_BSDMA>;
> + #address-cells = <2>;
> + #size-cells = <2>;
Same issue here as the decoder.
next prev parent reply other threads:[~2022-08-16 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 6:26 [V12,0/7] Enable two hardware jpeg encoder for MT8195 Irui Wang
2022-07-29 6:26 ` [V12,1/7] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible Irui Wang
2022-07-29 8:34 ` AngeloGioacchino Del Regno
2022-08-16 16:27 ` Rob Herring [this message]
2022-07-29 6:26 ` [V12,2/7] mtk-jpegenc: export jpeg encoder functions Irui Wang
2022-07-29 6:26 ` [V12,3/7] mtk-jpegenc: manage jpegenc multi-hardware Irui Wang
2022-08-03 11:35 ` Matthias Brugger
2022-07-29 6:26 ` [V12,4/7] mtk-jpegenc: add jpegenc timeout func interface Irui Wang
2022-07-29 6:26 ` [V12,5/7] mtk-jpegenc: add jpeg encode worker interface Irui Wang
2022-07-29 6:26 ` [V12,6/7] mtk-jpegenc: add output pic reorder interface Irui Wang
2022-07-29 6:26 ` [V12,7/7] mtk-jpegenc: add stop cmd interface for jpgenc Irui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816162700.GA2325543-robh@kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=kyrie.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=tfiga@chromium.org \
--cc=tzungbi@chromium.org \
--cc=wenst@chromium.org \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).