From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6A3C25B0E for ; Tue, 16 Aug 2022 20:52:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231529AbiHPUwf (ORCPT ); Tue, 16 Aug 2022 16:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237243AbiHPUwc (ORCPT ); Tue, 16 Aug 2022 16:52:32 -0400 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB61489CE3; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id w8so2717511ilj.5; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=EzR+Z4kxn7o2P/WW6PzrWm03607DFyihBAzL1aumsm4=; b=GjShtAUEc0BZSPQ9pNFMz/GraxfeASnqn1kuCqNwxLjoztR7FgLf3yeeR7ghBJyfrp 5XT2kjcRTnWaDMektSjx1DrmqfRVXXTO/jRPV1EKMEDXq4Z1XEqEXMGCqfd92kR1p/4/ xurHAUmPl40+FuZoT8XzL+Nt+YKhQFir05g+7XbiNkDq1PguKqh8WFWYQy1RtLl1h9rr hmF0JrKKFUQNnjfTYmq7YkyfU40l/KZ+/ZjfTf0RTKqi6KYD+LL+gFPNApGBfB13TO2p eCSKdgazRkKnSbu+1ewhj6OZCk3EcXj9CfU9OWojGItGQgNEXjDSTT4E+iDp5i8KkZLD koxg== X-Gm-Message-State: ACgBeo0wirYwWXsJoahyphfgZmAvcOIC3DtYwX5EmeyyVGWfkmBiW1dA aQRHsyuRxbK7nmbqpJD+tg== X-Google-Smtp-Source: AA6agR4sGyiJKaOIlOFFnF0gqYNlu2XfR46u2ykdYGuFEEDs2T7qsaoxAPvnZ50uBGOOW7Z0yR8c2A== X-Received: by 2002:a05:6e02:18cd:b0:2de:73e8:3f0 with SMTP id s13-20020a056e0218cd00b002de73e803f0mr10622659ilu.69.1660683151102; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id v30-20020a02b09e000000b00339dbd4c8d7sm4780229jah.45.2022.08.16.13.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:52:30 -0700 (PDT) Received: (nullmailer pid 2713686 invoked by uid 1000); Tue, 16 Aug 2022 20:52:28 -0000 Date: Tue, 16 Aug 2022 14:52:28 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?iso-8859-1?Q?Ren=E9?= van Dorst , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Message-ID: <20220816205228.GA2709277-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813154415.349091-3-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 13, 2022 at 06:44:10PM +0300, Arınç ÜNAL wrote: > - Fix description of mediatek,mcm. mediatek,mcm is not used on MT7623NI. > - Add description for reset-gpios. > - Invalidate reset-gpios if mediatek,mcm is used. > - Invalidate mediatek,mcm if the compatible device is mediatek,mt7531. > - Require mediatek,mcm for the described MT7621 SoCs as the compatible > string is only used for MT7530 which is a part of the multi-chip module. The commit message should answer 'why is this change needed/wanted?' not 'what changed'. I can read the diff to see what changed. d> > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 31 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index edf48e917173..4c99266ce82a 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -110,11 +110,15 @@ properties: > mediatek,mcm: > type: boolean > description: > - if defined, indicates that either MT7530 is the part on multi-chip > - module belong to MT7623A has or the remotely standalone chip as the > - function MT7623N reference board provided for. > + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 > + switch is a part of the multi-chip module. > > reset-gpios: > + description: > + GPIO to reset the switch. Use this if mediatek,mcm is not used. > + This property is optional because some boards share the reset line with > + other components which makes it impossible to probe the switch if the > + reset line is used. > maxItems: 1 > > reset-names: > @@ -165,6 +169,9 @@ allOf: > required: > - mediatek,mcm > then: > + properties: > + reset-gpios: false > + > required: > - resets > - reset-names > @@ -182,6 +189,24 @@ allOf: > - core-supply > - io-supply > > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7531 > + then: > + properties: > + mediatek,mcm: false > + > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7621 > + then: > + required: > + - mediatek,mcm > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 > >