* [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
@ 2022-08-17 14:05 Juerg Haefliger
2022-08-17 16:08 ` Neil Armstrong
2022-08-18 6:48 ` [PATCH v2] " Juerg Haefliger
0 siblings, 2 replies; 8+ messages in thread
From: Juerg Haefliger @ 2022-08-17 14:05 UTC (permalink / raw)
To: narmstrong, mchehab, gregkh, khilman, jbrunet,
martin.blumenstingl, linux-amlogic, linux-staging,
linux-arm-kernel
Cc: linux-kernel, Juerg Haefliger
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
.../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..c7750d4be848 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
.num_formats = ARRAY_SIZE(vdec_formats_sm1),
.revision = VDEC_REVISION_SM1,
};
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
2022-08-17 14:05 [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro Juerg Haefliger
@ 2022-08-17 16:08 ` Neil Armstrong
2022-08-18 6:44 ` Juerg Haefliger
2022-08-18 6:48 ` [PATCH v2] " Juerg Haefliger
1 sibling, 1 reply; 8+ messages in thread
From: Neil Armstrong @ 2022-08-17 16:08 UTC (permalink / raw)
To: Juerg Haefliger, mchehab, gregkh, khilman, jbrunet,
martin.blumenstingl, linux-amlogic, linux-staging,
linux-arm-kernel
Cc: linux-kernel
On 17/08/2022 16:05, Juerg Haefliger wrote:
> The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
> .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> index 88c9d72e1c83..c7750d4be848 100644
> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
> .num_formats = ARRAY_SIZE(vdec_formats_sm1),
> .revision = VDEC_REVISION_SM1,
> };
> +
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
Duplicate
> +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
DDDDDDDuplicate
> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
Duplicate
> +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
With the duplicate entries removed, please add my:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
2022-08-17 16:08 ` Neil Armstrong
@ 2022-08-18 6:44 ` Juerg Haefliger
0 siblings, 0 replies; 8+ messages in thread
From: Juerg Haefliger @ 2022-08-18 6:44 UTC (permalink / raw)
To: Neil Armstrong
Cc: mchehab, gregkh, khilman, jbrunet, martin.blumenstingl,
linux-amlogic, linux-staging, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]
On Wed, 17 Aug 2022 18:08:19 +0200
Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 17/08/2022 16:05, Juerg Haefliger wrote:
> > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> > provide that information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> > .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> > index 88c9d72e1c83..c7750d4be848 100644
> > --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
> > .num_formats = ARRAY_SIZE(vdec_formats_sm1),
> > .revision = VDEC_REVISION_SM1,
> > };
> > +
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
>
> Duplicate
Oh this is embarrassing :-(
> > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
>
> DDDDDDDuplicate
>
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
>
> Duplicate
>
> > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
>
> With the duplicate entries removed, please add my:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Will do. Thanks for the review.
...Juerg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] media: meson: vdec: Add MODULE_FIRMWARE macro
2022-08-17 14:05 [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro Juerg Haefliger
2022-08-17 16:08 ` Neil Armstrong
@ 2022-08-18 6:48 ` Juerg Haefliger
2023-01-26 15:32 ` [PATCH v2 resend] " Juerg Haefliger
1 sibling, 1 reply; 8+ messages in thread
From: Juerg Haefliger @ 2022-08-18 6:48 UTC (permalink / raw)
To: narmstrong, mchehab, gregkh, khilman, jbrunet,
martin.blumenstingl, linux-amlogic, linux-staging,
linux-arm-kernel
Cc: linux-kernel, Juerg Haefliger
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v2:
- Drop duplicates
- Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
.num_formats = ARRAY_SIZE(vdec_formats_sm1),
.revision = VDEC_REVISION_SM1,
};
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
2022-08-18 6:48 ` [PATCH v2] " Juerg Haefliger
@ 2023-01-26 15:32 ` Juerg Haefliger
2023-06-13 9:50 ` Juerg Haefliger
2023-06-13 15:39 ` [PATCH v2 resend 2] " Juerg Haefliger
0 siblings, 2 replies; 8+ messages in thread
From: Juerg Haefliger @ 2023-01-26 15:32 UTC (permalink / raw)
To: juerg.haefliger
Cc: gregkh, jbrunet, khilman, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-staging, martin.blumenstingl, mchehab,
narmstrong
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v2:
- Drop duplicates
- Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
.num_formats = ARRAY_SIZE(vdec_formats_sm1),
.revision = VDEC_REVISION_SM1,
};
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
2023-01-26 15:32 ` [PATCH v2 resend] " Juerg Haefliger
@ 2023-06-13 9:50 ` Juerg Haefliger
2023-06-13 9:59 ` Dan Carpenter
2023-06-13 15:39 ` [PATCH v2 resend 2] " Juerg Haefliger
1 sibling, 1 reply; 8+ messages in thread
From: Juerg Haefliger @ 2023-06-13 9:50 UTC (permalink / raw)
To: juerg.haefliger
Cc: gregkh, jbrunet, khilman, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-staging, martin.blumenstingl, mchehab,
narmstrong
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
Ping
> The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> ---
> v2:
> - Drop duplicates
> - Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> index 88c9d72e1c83..70c9fd7c8bc5 100644
> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> @@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
> .num_formats = ARRAY_SIZE(vdec_formats_sm1),
> .revision = VDEC_REVISION_SM1,
> };
> +
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
2023-06-13 9:50 ` Juerg Haefliger
@ 2023-06-13 9:59 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2023-06-13 9:59 UTC (permalink / raw)
To: Juerg Haefliger
Cc: gregkh, jbrunet, khilman, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-staging, martin.blumenstingl, mchehab,
narmstrong
On Tue, Jun 13, 2023 at 11:50:18AM +0200, Juerg Haefliger wrote:
> Ping
>
You CC'd almost a hundred different mailing lists but you left out the
one that matters. Resend and CC linux-media@vger.kernel.org
The linux-media maintainers work off patchwork so they'll never see this
patch as is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 resend 2] media: meson: vdec: Add MODULE_FIRMWARE macro
2023-01-26 15:32 ` [PATCH v2 resend] " Juerg Haefliger
2023-06-13 9:50 ` Juerg Haefliger
@ 2023-06-13 15:39 ` Juerg Haefliger
1 sibling, 0 replies; 8+ messages in thread
From: Juerg Haefliger @ 2023-06-13 15:39 UTC (permalink / raw)
To: juerg.haefliger
Cc: gregkh, jbrunet, khilman, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-staging, martin.blumenstingl, mchehab,
narmstrong, linux-media
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v2 resend 2:
- cc linux-media@vger.kernel.org
v2:
- Drop duplicates
- Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
.num_formats = ARRAY_SIZE(vdec_formats_sm1),
.revision = VDEC_REVISION_SM1,
};
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-06-13 15:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 14:05 [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro Juerg Haefliger
2022-08-17 16:08 ` Neil Armstrong
2022-08-18 6:44 ` Juerg Haefliger
2022-08-18 6:48 ` [PATCH v2] " Juerg Haefliger
2023-01-26 15:32 ` [PATCH v2 resend] " Juerg Haefliger
2023-06-13 9:50 ` Juerg Haefliger
2023-06-13 9:59 ` Dan Carpenter
2023-06-13 15:39 ` [PATCH v2 resend 2] " Juerg Haefliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).