From: Guenter Roeck <linux@roeck-us.net>
To: Eliav Farber <farbere@amazon.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, talel@amazon.com,
hhhawa@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
ronenk@amazon.com, itamark@amazon.com, shellykz@amazon.com,
shorer@amazon.com, amitlavi@amazon.com, almogbs@amazon.com,
dwmw@amazon.co.uk, rtanwar@maxlinear.com
Subject: Re: [PATCH v2 13/16] hwmon: (mr75203) add thermal coefficient properties for Moortec PVT controller
Date: Thu, 18 Aug 2022 13:25:31 -0700 [thread overview]
Message-ID: <20220818202531.GA3431466@roeck-us.net> (raw)
In-Reply-To: <20220817054321.6519-14-farbere@amazon.com>
On Wed, Aug 17, 2022 at 05:43:18AM +0000, Eliav Farber wrote:
> Add optional "ts-coeff-g", "ts-coeff-h", "ts-coeff-cal5" and
> "ts-coeff-j" properties to be used instead of defaults for the
> thermal equasion.
>
Vendor prefix again, and shouldn;t there be some note about the
to-be-used defaults ?
Guenter
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> .../bindings/hwmon/moortec,mr75203.yaml | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index e2a55001eefc..867664bd937f 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -62,6 +62,30 @@ properties:
> used to normalzie the voltage output results.
> $ref: /schemas/types.yaml#definitions/uint32
>
> + ts-coeff-g:
> + description:
> + G coefficient for thermal equation.
> + maxItems: 1
> + $ref: /schemas/types.yaml#definitions/uint32
> +
> + ts-coeff-h:
> + description:
> + H coefficient for thermal equation.
> + maxItems: 1
> + $ref: /schemas/types.yaml#definitions/uint32
> +
> + ts-coeff-cal5:
> + description:
> + cal5 coefficient for thermal equation (can't be 0).
> + maxItems: 1
> + $ref: /schemas/types.yaml#definitions/uint32
> +
> + ts-coeff-j:
> + description:
> + J coefficient for thermal equation.
> + maxItems: 1
> + $ref: /schemas/types.yaml#definitions/int32
> +
> required:
> - compatible
> - reg
> @@ -75,6 +99,10 @@ additionalProperties:
> - reset-control-skip
> - vm-active-channels
> - vm-pre-scalar-ch#
> + - ts-coeff-g
> + - ts-coeff-h
> + - ts-coeff-cal5
> + - ts-coeff-j
>
> examples:
> - |
> @@ -90,5 +118,10 @@ examples:
> resets = <&rcu0 0x40 7>;
> vm-active-channels = [08 10 02];
> vm-pre-scalar-ch5 = <2>;
> + ts-coeff-g = <57400>;
> + ts-coeff-h = <249400>;
> + ts-coeff-cal5 = <4096>;
> + ts-coeff-j = <0>;
> +
> #thermal-sensor-cells = <1>;
> };
next prev parent reply other threads:[~2022-08-18 20:25 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 5:43 [PATCH v2 00/16] Variety of fixes and new features for mr75203 driver Eliav Farber
2022-08-17 5:43 ` [PATCH v2 01/16] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" not defined Eliav Farber
2022-08-18 19:40 ` Guenter Roeck
2022-08-18 20:01 ` [PATCH v2 01/16] hwmon: (mr75203) fix VM sensor allocation when "intel, vm-map" " Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 02/16] hwmon: (mr75203) update pvt->v_num to the actual number of used sensors Eliav Farber
2022-08-18 19:44 ` Guenter Roeck
2022-08-17 5:43 ` [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel,vm-map property Eliav Farber
2022-08-18 19:47 ` Guenter Roeck
2022-08-18 20:20 ` [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel, vm-map property Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 04/16] hwmon: (mr75203) add Moortec PVT controller reset-control-skip property Eliav Farber
2022-08-18 20:01 ` Guenter Roeck
2022-08-22 11:54 ` Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 05/16] hwmon: (mr75203) add option to skip reset controller Eliav Farber
2022-08-17 5:43 ` [PATCH v2 06/16] hwmon: (mr75203) fix multi-channel voltage reading Eliav Farber
2022-08-18 20:03 ` Guenter Roeck
2022-08-22 12:37 ` Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 07/16] hwmon: (mr75203) add VM active channels property for Moortec PVT controller Eliav Farber
2022-08-18 20:07 ` Guenter Roeck
2022-08-17 5:43 ` [PATCH v2 08/16] hwmon: (mr75203) add VM active channel support Eliav Farber
2022-08-17 5:43 ` [PATCH v2 09/16] hwmon: (mr75203) add VM pre-scalar property for Moortec PVT controller Eliav Farber
2022-08-18 20:11 ` Guenter Roeck
2022-08-19 7:13 ` Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 10/16] hwmon: (mr75203) add VM pre-scalar support Eliav Farber
2022-08-17 5:43 ` [PATCH v2 11/16] hwmon: (mr75203) add protection for negative voltage value Eliav Farber
2022-08-18 20:13 ` Guenter Roeck
2022-08-17 5:43 ` [PATCH v2 12/16] hwmon: (mr75203) modify the temperature equation Eliav Farber
2022-08-18 20:23 ` Guenter Roeck
2022-08-19 7:44 ` Farber, Eliav
2022-08-19 11:35 ` Guenter Roeck
2022-08-17 5:43 ` [PATCH v2 13/16] hwmon: (mr75203) add thermal coefficient properties for Moortec PVT controller Eliav Farber
2022-08-18 20:25 ` Guenter Roeck [this message]
2022-08-22 13:24 ` Farber, Eliav
2022-08-22 16:25 ` Guenter Roeck
2022-08-29 18:46 ` Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 14/16] hwmon: (mr75203) parse thermal coefficients from device-tree Eliav Farber
2022-08-18 20:28 ` Guenter Roeck
2022-08-19 7:57 ` Farber, Eliav
2022-08-19 11:36 ` Guenter Roeck
2022-08-19 11:38 ` Guenter Roeck
2022-08-22 13:41 ` Farber, Eliav
2022-08-22 16:31 ` Guenter Roeck
2022-08-29 18:59 ` Farber, Eliav
2022-08-17 5:43 ` [PATCH v2 15/16] hwmon: (mr75203) fix coding style space errors Eliav Farber
2022-08-17 5:43 ` [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients Eliav Farber
2022-08-18 23:11 ` Guenter Roeck
2022-08-22 13:59 ` Farber, Eliav
2022-08-22 16:28 ` Guenter Roeck
2022-08-29 18:41 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818202531.GA3431466@roeck-us.net \
--to=linux@roeck-us.net \
--cc=almogbs@amazon.com \
--cc=amitlavi@amazon.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=rtanwar@maxlinear.com \
--cc=shellykz@amazon.com \
--cc=shorer@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).