From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pci-bridge-emul: Set position of PCI capabilities to real HW value
Date: Thu, 18 Aug 2022 18:02:55 -0500 [thread overview]
Message-ID: <20220818230255.GA2403243@bhelgaas> (raw)
In-Reply-To: <20220818223636.zohqfos6i22pbs7h@pali>
On Fri, Aug 19, 2022 at 12:36:36AM +0200, Pali Rohár wrote:
> On Thursday 18 August 2022 17:31:36 Bjorn Helgaas wrote:
> > On Thu, Aug 18, 2022 at 03:50:54PM +0200, Pali Rohár wrote:
> > > On Sunday 03 July 2022 12:46:27 Pali Rohár wrote:
> > > > mvebu and aardvark HW have PCIe capabilities on different offset in PCI
> > > > config space. Extend pci-bridge-emul.c code to allow setting custom driver
> > > > custom value where PCIe capabilities starts.
> > > >
> > > > With this change PCIe capabilities of both drivers are reported at the same
> > > > location as where they are reported by U-Boot - in their real HW offset.
> >
> > Just curious since I haven't read the patch, and Lorenzo will take
> > care of this anyway, but does this fix a bug, i.e., does something
> > work when it didn't work before? Or does everything *work* without
> > this patch, but lspci reports capabilities at different offsets than
> > U-Boot?
>
> The last sentence is correct. Everything works with and also without
> this patch. Just without this patch lspci reports capabilities at
> different offsets than what HW reports and what U-Boot reports (U-Boot
> already reports offsets same as in HW).
>
> So lets say, that with this patch, it is easier to compare pci config
> space dump from u-boot and linux. And this simplify debugging.
I agree, that's a really annoying difference. Seems like a good thing
to fix (again, not having looked at the patch, I have no opinion on
the implementation :)).
Bjorn
next prev parent reply other threads:[~2022-08-18 23:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 10:46 [PATCH] PCI: pci-bridge-emul: Set position of PCI capabilities to real HW value Pali Rohár
2022-08-18 13:50 ` Pali Rohár
2022-08-18 22:31 ` Bjorn Helgaas
2022-08-18 22:36 ` Pali Rohár
2022-08-18 23:02 ` Bjorn Helgaas [this message]
2022-08-23 9:06 ` Lorenzo Pieralisi
2022-08-23 9:25 ` Pali Rohár
2022-08-23 10:14 ` [PATCH v2] " Pali Rohár
2022-08-23 15:55 ` Lorenzo Pieralisi
2022-08-23 16:31 ` Pali Rohár
2022-08-24 7:25 ` Lorenzo Pieralisi
2022-08-24 10:33 ` Pali Rohár
2022-08-24 11:21 ` [PATCH v3] " Pali Rohár
2022-08-25 10:09 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818230255.GA2403243@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kabel@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).