From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Tom Zanussi <zanussi@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 5/6] tracing/probes: Have kprobes and uprobes use $COMM too
Date: Sun, 21 Aug 2022 11:40:53 -0400 [thread overview]
Message-ID: <20220821114053.1ba9fc65@gandalf.local.home> (raw)
In-Reply-To: <20220822001902.170ae2e078bba021581279e2@kernel.org>
On Mon, 22 Aug 2022 00:19:02 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> This looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks Masami. I was holding off sending these in hoping that you would
give an ack ;-)
>
> (Note that kprobes/uprobes doesn't need to record cpu/pid, because those
> are a part of common field and can be accessed from filter or histogram.
> Only comm must be recorded as string.)
Same for eprobes.
-- Steve
next prev parent reply other threads:[~2022-08-21 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 13:43 [PATCH v2 0/6] tracing/eprobes: Fixes for unexpected arguments Steven Rostedt
2022-08-20 13:43 ` [PATCH v2 1/6] tracing/eprobes: Do not allow eprobes to use $stack, or % for regs Steven Rostedt
2022-08-20 13:43 ` [PATCH v2 2/6] tracing/eprobes: Do not hardcode $comm as a string Steven Rostedt
2022-08-20 13:43 ` [PATCH v2 3/6] tracing/eprobes: Fix reading of string fields Steven Rostedt
2022-08-20 13:43 ` [PATCH v2 4/6] tracing/eprobes: Have event probes be consistent with kprobes and uprobes Steven Rostedt
2022-08-20 13:43 ` [PATCH v2 5/6] tracing/probes: Have kprobes and uprobes use $COMM too Steven Rostedt
2022-08-21 15:19 ` Masami Hiramatsu
2022-08-21 15:40 ` Steven Rostedt [this message]
2022-08-20 13:43 ` [PATCH v2 6/6] tracing: Have filter accept "common_cpu" to be consistent Steven Rostedt
2022-08-21 15:14 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821114053.1ba9fc65@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).