From: "Pali Rohár" <pali@kernel.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: jdelvare@suse.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (dell-smm) Add FW_BUG to SMM warning message
Date: Sun, 21 Aug 2022 17:43:23 +0200 [thread overview]
Message-ID: <20220821154323.h3htrvnw7wsbahzw@pali> (raw)
In-Reply-To: <20220821151713.11198-3-W_Armin@gmx.de>
On Sunday 21 August 2022 17:17:12 Armin Wolf wrote:
> When a SMM call takes very long to execute, then it definitely
> is a firmware bug which should be marked with FW_BUG.
> Also add the number of the buggy SMM call to the warning message
> so BIOS developers, etc immediately know which part of the SMM
> interface is buggy.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
Ideally this change should be CCed to Dell BIOS developers :D (hehe)
> ---
> drivers/hwmon/dell-smm-hwmon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 1dab7591576a..f7bab1a91b93 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -26,6 +26,7 @@
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> +#include <linux/printk.h>
> #include <linux/proc_fs.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> @@ -198,7 +199,7 @@ static int i8k_smm_func(void *par)
> eax, ebx, regs->eax & 0xffff, carry, duration);
>
> if (duration > DELL_SMM_MAX_DURATION)
> - pr_warn_once("SMM call took %lld usecs!\n", duration);
> + pr_warn_once(FW_BUG "SMM call 0x%.4x took %lld usecs!\n", eax, duration);
>
> if (carry || (regs->eax & 0xffff) == 0xffff || regs->eax == eax)
> return -EINVAL;
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-08-21 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 15:17 [PATCH 0/3] hwmon: (dell-smm) Minor fixes Armin Wolf
2022-08-21 15:17 ` [PATCH 1/3] hwmon: (dell-smm) Fail probing when cooling device registration fails Armin Wolf
2022-08-21 15:41 ` Pali Rohár
2022-08-21 19:11 ` Armin Wolf
2022-08-22 16:17 ` Guenter Roeck
2022-08-21 15:17 ` [PATCH 2/3] hwmon: (dell-smm) Add FW_BUG to SMM warning message Armin Wolf
2022-08-21 15:43 ` Pali Rohár [this message]
2022-08-21 15:17 ` [PATCH 3/3] hwmon: (dell-smm) Improve warning messages Armin Wolf
2022-08-21 15:46 ` Pali Rohár
2022-08-21 19:17 ` Armin Wolf
2022-08-22 16:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821154323.h3htrvnw7wsbahzw@pali \
--to=pali@kernel.org \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).