From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 250C3C28D13 for ; Mon, 22 Aug 2022 09:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234550AbiHVJoW (ORCPT ); Mon, 22 Aug 2022 05:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234028AbiHVJoS (ORCPT ); Mon, 22 Aug 2022 05:44:18 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5BB26565 for ; Mon, 22 Aug 2022 02:44:17 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27M5UW4B009136; Mon, 22 Aug 2022 04:44:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=KUDNYanUr3tKoXxWjUfjw2VgStT2U7oToW0OP5HRHlQ=; b=CjXjRw1zYnbqukvIi6yQfPwUJLHhQKE17tJ1SoEL0h9UeuKytfrbVlXcx7aWmWrA5UyJ X7GALinPjybwVIrfiRkSsQXxyAMUqpLkLHsvuzsPVqYAwLQFqhk6YfwCmjIwN727343m VmmFOs8kelhuj1czuJ3t7UWg95Iz8m2B4BK8Bu5k67WSvaW1AFmJP96gd13gpBm3RhZz QIjnFJsBGh+keoC8fQU7sYmlBIqsHnOOSYHjEspVT/FeH0v7tuG3XJ83b32cKYYgpYsl TleE0LWqwQ4yix9XyumJc0SOMR7X4veRdKN4L+7PWPoRFKHIfVz3xezLXt48+CUNzxGB vQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3j2x1e9xsb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 04:44:08 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Mon, 22 Aug 2022 04:44:07 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.9 via Frontend Transport; Mon, 22 Aug 2022 04:44:07 -0500 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 4A851B06; Mon, 22 Aug 2022 09:44:07 +0000 (UTC) Date: Mon, 22 Aug 2022 09:44:07 +0000 From: Charles Keepax To: Paul Cercueil CC: Lee Jones , , Subject: Re: [PATCH v2 21/30] mfd: arizona: Remove #ifdef guards for PM related functions Message-ID: <20220822094407.GL92394@ediswmail.ad.cirrus.com> References: <20220808174107.38676-1-paul@crapouillou.net> <20220808174107.38676-22-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220808174107.38676-22-paul@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: Kes5UL6EvI-fs9whM-NKReRfjB6kgFab X-Proofpoint-GUID: Kes5UL6EvI-fs9whM-NKReRfjB6kgFab X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2022 at 07:40:58PM +0200, Paul Cercueil wrote: > Use the new EXPORT_GPL_DEV_PM_OPS() and pm_ptr() macros to handle the PM > callbacks. > > These macros allow the PM functions to be automatically dropped by the > compiler when CONFIG_PM is disabled, without having to use #ifdef > guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil > --- Acked-by: Charles Keepax Thanks, Charles