From: Jonathan Cameron <jic23@kernel.org>
To: Ciprian Regus <ciprian.regus@analog.com>
Cc: <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: Add docs for LTC2499
Date: Mon, 22 Aug 2022 20:39:35 +0100 [thread overview]
Message-ID: <20220822203935.02cfb580@jic23-huawei> (raw)
In-Reply-To: <20220822202435.7dd54583@jic23-huawei>
On Mon, 22 Aug 2022 20:24:35 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 22 Aug 2022 15:51:04 +0300
> Ciprian Regus <ciprian.regus@analog.com> wrote:
>
> > Update the bindings documentation for ltc2497 to include the ltc2499.
> >
> > Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
> Looks fine to me. Maybe a separate patch to add the ltc2496 binding
> given the driver is included in this MAINTAINERS entry?
> A random comment inline.
>
> Jonathan
>
> > ---
> > Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 6 +++++-
> > MAINTAINERS | 1 +
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > index c1772b568cd1..7bb30eafc543 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > @@ -13,10 +13,14 @@ description: |
> > 16bit ADC supporting up to 16 single ended or 8 differential inputs.
> > I2C interface.
> >
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/2497fb.pdf
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/2499fe.pdf
> > +
> > properties:
> > compatible:
> > - const:
> > + enum:
> > lltc,ltc2497
> > + lltc,ltc2499
Oops. Benefit of Rob's build bot later.
enum:
- lltc,ltc2497
- lltc,ltc2499
Just goes to show how wonderful automatic checking is :)
Jonathan
> >
> > reg: true
> > vref-supply: true
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9d7f64dc0efe..3c847619ceb1 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1327,6 +1327,7 @@ W: https://ez.analog.com/linux-software-drivers
> > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
> > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
> > F: Documentation/devicetree/bindings/iio/*/adi,*
> > +F: Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > F: Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
>
> Unrelated question, but why is this here given the wild cards above match?
>
> > F: drivers/iio/*/ad*
> > F: drivers/iio/adc/ltc249*
next prev parent reply other threads:[~2022-08-22 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 12:51 [PATCH 0/3] Add support for LTC2499 ADC Ciprian Regus
2022-08-22 12:51 ` [PATCH 1/3] dt-bindings: iio: adc: Add docs for LTC2499 Ciprian Regus
2022-08-22 19:24 ` Jonathan Cameron
2022-08-22 19:39 ` Jonathan Cameron [this message]
2022-08-22 19:40 ` Rob Herring
2022-08-22 12:51 ` [PATCH 2/3] drivers: iio: adc: LTC2499 support Ciprian Regus
2022-08-22 19:37 ` Jonathan Cameron
2022-08-23 15:21 ` Andy Shevchenko
2022-08-24 12:15 ` Jonathan Cameron
2022-08-29 6:30 ` Regus, Ciprian
2022-08-29 16:47 ` Jonathan Cameron
2022-08-22 12:51 ` [PATCH 3/3] drivers: iio: adc: Rename the LTC249x iio device Ciprian Regus
2022-08-22 14:08 ` Lars-Peter Clausen
2022-08-22 19:17 ` Jonathan Cameron
2022-08-29 6:13 ` Regus, Ciprian
2022-08-29 16:03 ` Jonathan Cameron
2022-08-23 11:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822203935.02cfb580@jic23-huawei \
--to=jic23@kernel.org \
--cc=ciprian.regus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).