From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com
Cc: linux-kernel@vger.kernel.org, yang.zhong@intel.com,
chang.seok.bae@intel.com
Subject: [RFC PATCH 0/2] KVM: x86: Add a new attribute to control dynamic XSTATE components
Date: Tue, 23 Aug 2022 16:14:00 -0700 [thread overview]
Message-ID: <20220823231402.7839-1-chang.seok.bae@intel.com> (raw)
Hi KVM folks,
While documenting the ARCH_{REQ|GET}_XCOMP_GUEST_PERM options [1], I came
to think of this new attribute as it can provide more consistent way of
enabling dynamic features for QEMU/KVM.
== Background ==
The new x86 arch_prctl() options [2] help to support dynamic AMX state
enabling. As the VCPU permission should be separate, additional options are
added for the userspace VMM like QEMU: ARCH_GET_XCOMP_GUEST_PERM and
ARCH_REQ_XCOMP_GUEST_PERM.
== Problem ==
KVM has already established a set of ioctls to control VM attributes. It
has the attribute to expose the KVM-supported XSTATE components [3].
This interface, however, is not necessarily compatible with those
arch_prctl() options. KVM may choose and expose some of the host-supported
features. Then using the host-provided interface may not comply with this
KVM policy.
== Solution ==
The patchset adds a new attribute to control XSTATE permission:
KVM_X86_XCOMP_GUEST_PERM, and it is available through the
KVM_GET_DEVICE_ATTR/KVM_SET_DEVICE_ATTR APIs. The KVM AMX test is updated
to use this. Then QEMU may switch to keep using the KVM API, which is more
consistent.
[1]: https://lore.kernel.org/lkml/ec95b28f-51a1-a9cf-7d72-a3a865797c7d@intel.com/
[2]: https://docs.kernel.org/x86/xstate.html
[3]: https://gitlab.com/qemu-project/qemu/-/blob/master/linux-headers/asm-x86/kvm.h#L456
Chang S. Bae (2):
KVM: x86: Add a new system attribute for dynamic XSTATE component
selftests: kvm: Use the KVM API to enable dynamic XSTATE features
arch/x86/include/asm/fpu/api.h | 1 +
arch/x86/include/uapi/asm/kvm.h | 1 +
arch/x86/kernel/fpu/xstate.c | 6 ++++
arch/x86/kvm/x86.c | 31 +++++++++++++++++++
tools/arch/x86/include/uapi/asm/kvm.h | 1 +
.../selftests/kvm/lib/x86_64/processor.c | 22 +++++++++----
6 files changed, 56 insertions(+), 6 deletions(-)
base-commit: 1c23f9e627a7b412978b4e852793c5e3c3efc555
--
2.17.1
next reply other threads:[~2022-08-23 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 23:14 Chang S. Bae [this message]
2022-08-23 23:14 ` [RFC PATCH 1/2] KVM: x86: Add a new system attribute for dynamic XSTATE component Chang S. Bae
2022-08-24 21:42 ` Sean Christopherson
2022-08-24 22:49 ` Chang S. Bae
2022-08-25 16:19 ` Sean Christopherson
2022-08-25 20:45 ` Chang S. Bae
2022-08-25 21:54 ` Sean Christopherson
2022-08-23 23:14 ` [RFC PATCH 2/2] selftests: kvm: Use the KVM API to enable dynamic XSTATE features Chang S. Bae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823231402.7839-1-chang.seok.bae@intel.com \
--to=chang.seok.bae@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).